All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yiannis Marangos <yiannis.marangos@gmail.com>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Cc: Yiannis Marangos <yiannis.marangos@gmail.com>
Subject: [PATCH v3 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
Date: Sun,  5 Nov 2017 19:09:50 +0200	[thread overview]
Message-ID: <20171105170951.20261-2-yiannis.marangos@gmail.com> (raw)
In-Reply-To: <20171105170951.20261-1-yiannis.marangos@gmail.com>

Some synaptics devices such as LEN0073 use SMBUS version 3.

Signed-off-by: Yiannis Marangos <yiannis.marangos@gmail.com>
---
 drivers/input/rmi4/rmi_smbus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
index 225025a0940c..b6ccf39c6a7b 100644
--- a/drivers/input/rmi4/rmi_smbus.c
+++ b/drivers/input/rmi4/rmi_smbus.c
@@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
 	rmi_smb->xport.dev = &client->dev;
 	rmi_smb->xport.pdata = *pdata;
 	rmi_smb->xport.pdata.irq = client->irq;
-	rmi_smb->xport.proto_name = "smb2";
+	rmi_smb->xport.proto_name = "smb";
 	rmi_smb->xport.ops = &rmi_smb_ops;
 
 	smbus_version = rmi_smb_get_version(rmi_smb);
@@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
 	rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
 		smbus_version);
 
-	if (smbus_version != 2) {
+	if (smbus_version != 2 && smbus_version != 3) {
 		dev_err(&client->dev, "Unrecognized SMB version %d\n",
 				smbus_version);
 		return -ENODEV;
-- 
2.14.3


  reply	other threads:[~2017-11-05 17:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 17:09 [PATCH v3 0/3] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-11-05 17:09 ` Yiannis Marangos [this message]
2017-11-06  7:56   ` [PATCH v3 1/2] " Benjamin Tissoires
2017-11-08  0:24     ` Dmitry Torokhov
2017-11-05 17:09 ` [PATCH v3 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105170951.20261-2-yiannis.marangos@gmail.com \
    --to=yiannis.marangos@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.