From: Ladislav Michl <ladis@linux-mips.org> To: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org Cc: Boris Brezillon <boris.brezillon@free-electrons.com>, Aaro Koskinen <aaro.koskinen@iki.fi>, Tony Lindgren <tony@atomide.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Kyungmin Park <kyungmin.park@samsung.com>, Roger Quadros <rogerq@ti.com> Subject: [PATCH v5 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Date: Wed, 15 Nov 2017 17:30:27 +0100 [thread overview] Message-ID: <20171115163027.um34nsjacvd3xy3u@lenoch> (raw) In-Reply-To: <20171115162306.2o2w2yrf7wucroxd@lenoch> Use wait_for_completion_io_timeout, which has an impact on how the task is accounted in scheduling stats. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Acked-by: Roger Quadros <rogerq@ti.com> Tested-by: Tony Lindgren <tony@atomide.com> --- Changes in v5: None Changes in v4: - new patch Changes in v3: None Changes in v2: None drivers/mtd/onenand/omap2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index 883993bbe40b..0e7772e16d75 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state) if (result == 0) { int retry_cnt = 0; retry: - result = wait_for_completion_timeout(&c->irq_done, - msecs_to_jiffies(20)); - if (result == 0) { + if (!wait_for_completion_io_timeout(&c->irq_done, + msecs_to_jiffies(20))) { /* Timeout after 20ms */ ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS); if (ctrl & ONENAND_CTRL_ONGO && -- 2.11.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Ladislav Michl <ladis@linux-mips.org> To: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org Cc: Roger Quadros <rogerq@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Kyungmin Park <kyungmin.park@samsung.com>, Aaro Koskinen <aaro.koskinen@iki.fi>, Tony Lindgren <tony@atomide.com> Subject: [PATCH v5 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Date: Wed, 15 Nov 2017 17:30:27 +0100 [thread overview] Message-ID: <20171115163027.um34nsjacvd3xy3u@lenoch> (raw) In-Reply-To: <20171115162306.2o2w2yrf7wucroxd@lenoch> Use wait_for_completion_io_timeout, which has an impact on how the task is accounted in scheduling stats. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Acked-by: Roger Quadros <rogerq@ti.com> Tested-by: Tony Lindgren <tony@atomide.com> --- Changes in v5: None Changes in v4: - new patch Changes in v3: None Changes in v2: None drivers/mtd/onenand/omap2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index 883993bbe40b..0e7772e16d75 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state) if (result == 0) { int retry_cnt = 0; retry: - result = wait_for_completion_timeout(&c->irq_done, - msecs_to_jiffies(20)); - if (result == 0) { + if (!wait_for_completion_io_timeout(&c->irq_done, + msecs_to_jiffies(20))) { /* Timeout after 20ms */ ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS); if (ctrl & ONENAND_CTRL_ONGO && -- 2.11.0
next prev parent reply other threads:[~2017-11-15 16:30 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 16:23 [PATCH v5 00/16] OMAP2+ OneNAND driver update Ladislav Michl 2017-11-15 16:23 ` Ladislav Michl 2017-11-15 16:24 ` [PATCH v5 01/16] dt-bindings: mtd: gpmc-onenand: Update properties description Ladislav Michl 2017-11-15 16:24 ` Ladislav Michl 2017-11-30 10:25 ` Boris Brezillon 2017-11-30 10:25 ` Boris Brezillon 2017-11-30 13:09 ` Ladislav Michl 2017-11-30 13:09 ` Ladislav Michl 2017-12-15 10:18 ` Roger Quadros 2017-12-15 10:18 ` Roger Quadros [not found] ` <23d7ad3c-e6cd-3ba6-269a-1788371d13c3-l0cyMroinI0@public.gmane.org> 2017-12-15 12:24 ` Ladislav Michl 2017-12-15 12:24 ` Ladislav Michl 2017-11-15 16:26 ` [PATCH v5 02/16] ARM: dts: OMAP2+: Add compatible property to onenand node Ladislav Michl 2017-11-15 16:26 ` Ladislav Michl 2017-11-15 16:26 ` [PATCH v5 03/16] ARM: dts: omap3-igep: Update onenand node timings Ladislav Michl 2017-11-15 16:26 ` Ladislav Michl 2017-11-15 16:27 ` [PATCH v5 04/16] mtd: onenand: omap2: Remove regulator support Ladislav Michl 2017-11-15 16:27 ` Ladislav Michl 2017-11-15 16:28 ` [PATCH v5 05/16] mtd: onenand: omap2: Remove skip initial unlocking support Ladislav Michl 2017-11-15 16:28 ` Ladislav Michl 2017-11-15 16:29 ` [PATCH v5 06/16] mtd: onenand: omap2: Remove partitioning support from platform data Ladislav Michl 2017-11-15 16:29 ` Ladislav Michl 2017-11-15 16:30 ` Ladislav Michl [this message] 2017-11-15 16:30 ` [PATCH v5 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Ladislav Michl 2017-11-15 16:31 ` [PATCH v5 08/16] mtd: onenand: omap2: Simplify the DMA setup for various paths Ladislav Michl 2017-11-15 16:31 ` Ladislav Michl 2017-11-15 16:32 ` [PATCH v5 09/16] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Ladislav Michl 2017-11-15 16:32 ` Ladislav Michl 2017-11-15 16:33 ` [PATCH v5 10/16] mtd: onenand: omap2: Convert to use dmaengine for memcpy Ladislav Michl 2017-11-15 16:33 ` Ladislav Michl 2017-11-15 16:34 ` [PATCH v5 11/16] mtd: onenand: omap2: Do not make delay for GPIO OMAP3 specific Ladislav Michl 2017-11-15 16:34 ` Ladislav Michl 2017-11-15 16:35 ` [PATCH v5 12/16] mtd: onenand: omap2: Decouple DMA enabling from INT pin availability Ladislav Michl 2017-11-15 16:35 ` Ladislav Michl 2017-11-15 16:36 ` [PATCH v5 13/16] memory: omap-gpmc: Refactor OneNAND support Ladislav Michl 2017-11-15 16:36 ` Ladislav Michl 2017-11-15 16:37 ` [PATCH v5 14/16] mtd: onenand: omap2: Configure driver from DT Ladislav Michl 2017-11-15 16:37 ` Ladislav Michl 2017-11-15 16:38 ` [PATCH v5 15/16] ARM: OMAP2+: Remove gpmc-onenand Ladislav Michl 2017-11-15 16:38 ` Ladislav Michl 2017-11-15 16:38 ` [PATCH v5 16/16] ARM: dts: Nokia: Use OneNAND INT pin Ladislav Michl 2017-11-15 16:38 ` Ladislav Michl 2017-11-30 10:18 ` [PATCH v5 00/16] OMAP2+ OneNAND driver update Boris Brezillon 2017-11-30 10:18 ` Boris Brezillon 2017-11-30 13:13 ` Ladislav Michl 2017-11-30 13:13 ` Ladislav Michl 2017-11-30 16:09 ` Tony Lindgren 2017-11-30 16:09 ` Tony Lindgren 2017-12-01 13:43 ` Roger Quadros 2017-12-01 13:43 ` Roger Quadros 2018-01-09 13:08 ` Ladislav Michl 2018-01-09 13:08 ` Ladislav Michl 2018-01-09 21:01 ` Aaro Koskinen 2018-01-09 21:01 ` Aaro Koskinen 2018-01-10 9:20 ` Ladislav Michl 2018-01-10 9:20 ` Ladislav Michl 2018-01-10 17:35 ` Aaro Koskinen 2018-01-10 17:35 ` Aaro Koskinen [not found] ` <20180110173519.xyug4egltni4f3qi-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org> 2018-01-10 21:13 ` Ladislav Michl 2018-01-10 21:13 ` Ladislav Michl 2018-01-11 19:29 ` Aaro Koskinen 2018-01-11 19:29 ` Aaro Koskinen [not found] ` <20180111192931.vwnpvj2wtgrvkhbe-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org> 2018-01-11 19:38 ` Ladislav Michl 2018-01-11 19:38 ` Ladislav Michl 2018-01-10 21:27 ` Aaro Koskinen 2018-01-10 21:27 ` Aaro Koskinen 2018-01-11 8:08 ` Roger Quadros 2018-01-11 8:08 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171115163027.um34nsjacvd3xy3u@lenoch \ --to=ladis@linux-mips.org \ --cc=aaro.koskinen@iki.fi \ --cc=boris.brezillon@free-electrons.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=peter.ujfalusi@ti.com \ --cc=rogerq@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.