All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	Guan Junxiong <guanjunxiong@huawei.com>
Cc: dm-devel@redhat.com
Subject: [PATCH 1/4] libmultipath: path latency: fix default base num
Date: Sat, 18 Nov 2017 01:11:31 +0100	[thread overview]
Message-ID: <20171118001134.26622-2-mwilck@suse.com> (raw)
In-Reply-To: <20171118001134.26622-1-mwilck@suse.com>

I don't think anyone can measure latency to 1% accuracy. It's
better to not even pretend to be able to. 10% should be fine
even for the most latency-critical environments.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 libmultipath/prioritizers/path_latency.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libmultipath/prioritizers/path_latency.c b/libmultipath/prioritizers/path_latency.c
index 9d5397ec1b3a..b8c5bc7c50a4 100644
--- a/libmultipath/prioritizers/path_latency.c
+++ b/libmultipath/prioritizers/path_latency.c
@@ -42,8 +42,9 @@
 #define DEF_IO_NUM		100
 
 #define MAX_BASE_NUM		10
-#define MIN_BASE_NUM		1.01
-#define DEF_BASE_NUM		1.5
+#define MIN_BASE_NUM		1.1
+// This is 10**(1/4). 4 prio steps correspond to a factor of 10.
+#define DEF_BASE_NUM		1.77827941004
 
 #define MAX_AVG_LATENCY		100000000.	/* Unit: us */
 #define MIN_AVG_LATENCY		1.		/* Unit: us */
-- 
2.15.0

  reply	other threads:[~2017-11-18  0:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  0:11 [PATCH 0/4] path latency prio fixes Martin Wilck
2017-11-18  0:11 ` Martin Wilck [this message]
2017-11-19  2:19   ` [PATCH 1/4] libmultipath: path latency: fix default base num Guan Junxiong
2017-11-18  0:11 ` [PATCH 2/4] libmultipath: path latency: log threshold with p2 Martin Wilck
2017-11-19  2:23   ` Guan Junxiong
2017-11-18  0:11 ` [PATCH 3/4] libmultipath: path latency: simplify getprio() Martin Wilck
2017-11-19  2:52   ` Guan Junxiong
2017-11-20  8:46     ` Martin Wilck
2017-12-07  4:26   ` Guan Junxiong
2017-12-07 15:56     ` Martin Wilck
2017-11-18  0:11 ` [PATCH 4/4] libmultipath: path latency: remove warnings Martin Wilck
2017-11-19  3:00   ` Guan Junxiong
2017-11-20  9:11 ` [PATCH 0/4] path latency prio fixes Martin Wilck
2017-12-08 20:49   ` Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171118001134.26622-2-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=guanjunxiong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.