From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH] build: disarm the TCG unit test trap
Date: Mon, 20 Nov 2017 17:17:28 +0000 [thread overview]
Message-ID: <20171120171728.31266-1-berrange@redhat.com> (raw)
Developers sometimes mistakenly run 'make test' instead of 'make check'.
'make test' triggers the ancient, unmaintained tcg unit tests in
tests/tcg/Makefile which have long since ceased compiling.
Even if someone fixes the TCG tests, it makes little sense to put
them in a 'make test' target, rather they should be 'make check-tcg',
possibly wired up as a dependency of 'make check'.
In the meantime, this patch disarms the 'make test' trap by turning
it into a synonym for 'make check'.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
tests/Makefile.include | 1 +
tests/tcg/Makefile | 3 ---
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 434a2ce868..55fd99f451 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -919,6 +919,7 @@ check-unit: $(patsubst %,check-%, $(check-unit-y))
check-speed: $(patsubst %,check-%, $(check-speed-y))
check-block: $(patsubst %,check-%, $(check-block-y))
check: check-qapi-schema check-unit check-qtest
+test: check
check-clean:
$(MAKE) -C tests/tcg clean
rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)
diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
index 89e3342f3d..4b5d196326 100644
--- a/tests/tcg/Makefile
+++ b/tests/tcg/Makefile
@@ -36,9 +36,6 @@ ifneq ($(call find-in-path, $(CC_I386)),)
TESTS += $(I386_TESTS)
endif
-all: $(patsubst %,run-%,$(TESTS))
-test: all
-
# rules to run tests
.PHONY: $(patsubst %,run-%,$(TESTS))
--
2.14.3
next reply other threads:[~2017-11-20 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 17:17 Daniel P. Berrange [this message]
2017-11-20 17:25 ` [Qemu-devel] [PATCH] build: disarm the TCG unit test trap Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120171728.31266-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.