From: Grygorii Strashko <grygorii.strashko@ti.com> To: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org> Cc: Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>, Murali Karicheri <m-karicheri2@ti.com>, Grygorii Strashko <grygorii.strashko@ti.com> Subject: [PATCH 07/11] net: ethernet: ti: ale: disable ale from stop() Date: Wed, 22 Nov 2017 15:25:53 -0600 [thread overview] Message-ID: <20171122212557.9998-8-grygorii.strashko@ti.com> (raw) In-Reply-To: <20171122212557.9998-1-grygorii.strashko@ti.com> ALE is enabled from cpsw_ale_start() now, but disabled only from cpsw_ale_destroy() which introduces inconsitance as cpsw_ale_start() is called when netif[s] is opened, but cpsw_ale_destroy() is called when driver is removed. Hence, move ALE disabling in cpsw_ale_stop(). Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ethernet/ti/cpsw_ale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c index b21ed3d..322f87c 100644 --- a/drivers/net/ethernet/ti/cpsw_ale.c +++ b/drivers/net/ethernet/ti/cpsw_ale.c @@ -870,6 +870,7 @@ EXPORT_SYMBOL_GPL(cpsw_ale_start); void cpsw_ale_stop(struct cpsw_ale *ale) { del_timer_sync(&ale->timer); + cpsw_ale_control_set(ale, 0, ALE_ENABLE, 0); } EXPORT_SYMBOL_GPL(cpsw_ale_stop); @@ -892,7 +893,6 @@ int cpsw_ale_destroy(struct cpsw_ale *ale) { if (!ale) return -EINVAL; - cpsw_ale_control_set(ale, 0, ALE_ENABLE, 0); kfree(ale); return 0; } -- 2.10.5
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org Cc: Sekhar Nori <nsekhar@ti.com>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>, Murali Karicheri <m-karicheri2@ti.com>, Grygorii Strashko <grygorii.strashko@ti.com> Subject: [PATCH 07/11] net: ethernet: ti: ale: disable ale from stop() Date: Wed, 22 Nov 2017 15:25:53 -0600 [thread overview] Message-ID: <20171122212557.9998-8-grygorii.strashko@ti.com> (raw) In-Reply-To: <20171122212557.9998-1-grygorii.strashko@ti.com> ALE is enabled from cpsw_ale_start() now, but disabled only from cpsw_ale_destroy() which introduces inconsitance as cpsw_ale_start() is called when netif[s] is opened, but cpsw_ale_destroy() is called when driver is removed. Hence, move ALE disabling in cpsw_ale_stop(). Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ethernet/ti/cpsw_ale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c index b21ed3d..322f87c 100644 --- a/drivers/net/ethernet/ti/cpsw_ale.c +++ b/drivers/net/ethernet/ti/cpsw_ale.c @@ -870,6 +870,7 @@ EXPORT_SYMBOL_GPL(cpsw_ale_start); void cpsw_ale_stop(struct cpsw_ale *ale) { del_timer_sync(&ale->timer); + cpsw_ale_control_set(ale, 0, ALE_ENABLE, 0); } EXPORT_SYMBOL_GPL(cpsw_ale_stop); @@ -892,7 +893,6 @@ int cpsw_ale_destroy(struct cpsw_ale *ale) { if (!ale) return -EINVAL; - cpsw_ale_control_set(ale, 0, ALE_ENABLE, 0); kfree(ale); return 0; } -- 2.10.5
next prev parent reply other threads:[~2017-11-22 21:26 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-22 21:25 [PATCH 00/11] net: ethernet: ti: cpsw/ale clean up and optimization Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 01/11] net: ethernet: ti: cpsw: drop unused var poll from cpsw_update_channels_res Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 02/11] net: ethernet: ti: cpsw: use proper io apis Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 03/11] net: ethernet: ti: cpsw: move platform data struct to .c file Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 04/11] net: ethernet: ti: cpsw: move mac_hi/lo defines in cpsw.h Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 05/11] net: ethernet: ti: cpsw: fix ale port numbers Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 06/11] net: ethernet: ti: ale: use proper io apis Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko [this message] 2017-11-22 21:25 ` [PATCH 07/11] net: ethernet: ti: ale: disable ale from stop() Grygorii Strashko 2017-11-22 21:25 ` [PATCH 08/11] net: ethernet: ti: ale: optimize ale entry mask bits configuartion Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 09/11] net: ethernet: ti: ale: move static initialization in cpsw_ale_create() Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 10/11] net: ethernet: ti: ale: use devm_kzalloc " Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-22 21:25 ` [PATCH 11/11] net: ethernet: ti: ale: fix port check in cpsw_ale_control_set/get Grygorii Strashko 2017-11-22 21:25 ` Grygorii Strashko 2017-11-23 18:09 ` [PATCH 00/11] net: ethernet: ti: cpsw/ale clean up and optimization David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171122212557.9998-8-grygorii.strashko@ti.com \ --to=grygorii.strashko@ti.com \ --cc=davem@davemloft.net \ --cc=ivan.khoronzhuk@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=m-karicheri2@ti.com \ --cc=netdev@vger.kernel.org \ --cc=nsekhar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.