From: "Radim Krčmář" <rkrcmar@redhat.com> To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Andrea Arcangeli" <aarcange@redhat.com>, "Jérôme Glisse" <jglisse@redhat.com> Subject: [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier Date: Thu, 30 Nov 2017 19:05:46 +0100 [thread overview] Message-ID: <20171130180546.4331-2-rkrcmar@redhat.com> (raw) In-Reply-To: <20171130180546.4331-1-rkrcmar@redhat.com> Does roughly what kvm_mmu_notifier_invalidate_page did before. I am not certain why this would be needed. It might mean that we have another bug with start/end or just that I missed something. Please try just [1/2] first and apply this one only if [1/2] still bugs, thanks! --- virt/kvm/kvm_main.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b7f4689e373f..0825ea624f16 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -342,6 +342,29 @@ static void kvm_mmu_notifier_change_pte(struct mmu_notifier *mn, srcu_read_unlock(&kvm->srcu, idx); } +static void kvm_mmu_notifier_invalidate_range(struct mmu_notifier *mn, + struct mm_struct *mm, + unsigned long start, + unsigned long end) +{ + struct kvm *kvm = mmu_notifier_to_kvm(mn); + int need_tlb_flush = 0, idx; + + idx = srcu_read_lock(&kvm->srcu); + spin_lock(&kvm->mmu_lock); + kvm->mmu_notifier_seq++; + need_tlb_flush = kvm_unmap_hva_range(kvm, start, end); + need_tlb_flush |= kvm->tlbs_dirty; + if (need_tlb_flush) + kvm_flush_remote_tlbs(kvm); + + spin_unlock(&kvm->mmu_lock); + + kvm_arch_mmu_notifier_invalidate_range(kvm, start, end); + + srcu_read_unlock(&kvm->srcu, idx); +} + static void kvm_mmu_notifier_invalidate_range_start(struct mmu_notifier *mn, struct mm_struct *mm, unsigned long start, @@ -476,6 +499,7 @@ static void kvm_mmu_notifier_release(struct mmu_notifier *mn, } static const struct mmu_notifier_ops kvm_mmu_notifier_ops = { + .invalidate_range = kvm_mmu_notifier_invalidate_range, .invalidate_range_start = kvm_mmu_notifier_invalidate_range_start, .invalidate_range_end = kvm_mmu_notifier_invalidate_range_end, .clear_flush_young = kvm_mmu_notifier_clear_flush_young, -- 2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com> To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Andrea Arcangeli" <aarcange@redhat.com>, "Jérôme Glisse" <jglisse@redhat.com> Subject: [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier Date: Thu, 30 Nov 2017 19:05:46 +0100 [thread overview] Message-ID: <20171130180546.4331-2-rkrcmar@redhat.com> (raw) In-Reply-To: <20171130180546.4331-1-rkrcmar@redhat.com> Does roughly what kvm_mmu_notifier_invalidate_page did before. I am not certain why this would be needed. It might mean that we have another bug with start/end or just that I missed something. Please try just [1/2] first and apply this one only if [1/2] still bugs, thanks! --- virt/kvm/kvm_main.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b7f4689e373f..0825ea624f16 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -342,6 +342,29 @@ static void kvm_mmu_notifier_change_pte(struct mmu_notifier *mn, srcu_read_unlock(&kvm->srcu, idx); } +static void kvm_mmu_notifier_invalidate_range(struct mmu_notifier *mn, + struct mm_struct *mm, + unsigned long start, + unsigned long end) +{ + struct kvm *kvm = mmu_notifier_to_kvm(mn); + int need_tlb_flush = 0, idx; + + idx = srcu_read_lock(&kvm->srcu); + spin_lock(&kvm->mmu_lock); + kvm->mmu_notifier_seq++; + need_tlb_flush = kvm_unmap_hva_range(kvm, start, end); + need_tlb_flush |= kvm->tlbs_dirty; + if (need_tlb_flush) + kvm_flush_remote_tlbs(kvm); + + spin_unlock(&kvm->mmu_lock); + + kvm_arch_mmu_notifier_invalidate_range(kvm, start, end); + + srcu_read_unlock(&kvm->srcu, idx); +} + static void kvm_mmu_notifier_invalidate_range_start(struct mmu_notifier *mn, struct mm_struct *mm, unsigned long start, @@ -476,6 +499,7 @@ static void kvm_mmu_notifier_release(struct mmu_notifier *mn, } static const struct mmu_notifier_ops kvm_mmu_notifier_ops = { + .invalidate_range = kvm_mmu_notifier_invalidate_range, .invalidate_range_start = kvm_mmu_notifier_invalidate_range_start, .invalidate_range_end = kvm_mmu_notifier_invalidate_range_end, .clear_flush_young = kvm_mmu_notifier_clear_flush_young, -- 2.14.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-30 18:06 UTC|newest] Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-29 23:54 [PATCH 00/13] mmu_notifier kill invalidate_page callback Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 01/13] dax: update to new mmu_notifier semantic Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 02/13] mm/rmap: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 2:46 ` Nadav Amit 2017-08-30 2:46 ` Nadav Amit 2017-08-30 2:59 ` Jerome Glisse 2017-08-30 2:59 ` Jerome Glisse 2017-08-30 3:16 ` Nadav Amit 2017-08-30 3:16 ` Nadav Amit 2017-08-30 3:18 ` Nadav Amit 2017-08-30 3:18 ` Nadav Amit 2017-08-30 17:27 ` Andrea Arcangeli 2017-08-30 17:27 ` Andrea Arcangeli 2017-08-30 18:00 ` Nadav Amit 2017-08-30 18:00 ` Nadav Amit 2017-08-30 21:25 ` Andrea Arcangeli 2017-08-30 21:25 ` Andrea Arcangeli 2017-08-30 23:25 ` Nadav Amit 2017-08-30 23:25 ` Nadav Amit 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 19:15 ` Nadav Amit 2017-08-31 19:15 ` Nadav Amit 2017-08-30 18:20 ` Jerome Glisse 2017-08-30 18:20 ` Jerome Glisse 2017-08-30 18:40 ` Nadav Amit 2017-08-30 18:40 ` Nadav Amit 2017-08-30 20:45 ` Jerome Glisse 2017-08-30 20:45 ` Jerome Glisse 2017-08-30 22:17 ` Andrea Arcangeli 2017-08-30 22:17 ` Andrea Arcangeli 2017-08-30 20:55 ` Andrea Arcangeli 2017-08-30 20:55 ` Andrea Arcangeli 2017-08-30 16:52 ` Andrea Arcangeli 2017-08-30 16:52 ` Andrea Arcangeli 2017-08-30 17:48 ` Jerome Glisse 2017-08-30 17:48 ` Jerome Glisse 2017-08-30 21:53 ` Linus Torvalds 2017-08-30 21:53 ` Linus Torvalds 2017-08-30 23:01 ` Andrea Arcangeli 2017-08-30 23:01 ` Andrea Arcangeli 2017-08-31 18:25 ` Jerome Glisse 2017-08-31 18:25 ` Jerome Glisse 2017-08-31 19:40 ` Linus Torvalds 2017-08-31 19:40 ` Linus Torvalds 2017-08-29 23:54 ` [PATCH 03/13] powerpc/powernv: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 04/13] drm/amdgpu: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 6:18 ` Christian König 2017-08-30 6:18 ` Christian König 2017-08-29 23:54 ` [PATCH 05/13] IB/umem: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 6:13 ` Leon Romanovsky 2017-08-29 23:54 ` [PATCH 06/13] IB/hfi1: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-09-06 14:08 ` Arumugam, Kamenee 2017-08-29 23:54 ` [PATCH 07/13] iommu/amd: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 08/13] iommu/intel: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 09/13] misc/mic/scif: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 10/13] sgi-gru: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 11/13] xen/gntdev: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 19:32 ` Boris Ostrovsky 2017-08-30 19:32 ` Boris Ostrovsky 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 12/13] KVM: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 13/13] mm/mmu_notifier: kill invalidate_page Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse [not found] ` <20170829235447.10050-1-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-30 0:11 ` [PATCH 00/13] mmu_notifier kill invalidate_page callback Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:50 ` taskboxtester 2017-09-01 14:50 ` taskboxtester 2017-08-30 21:51 ` Felix Kuehling 2017-08-31 13:59 ` Jerome Glisse [not found] ` <20170831135953.GA9227-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-31 14:14 ` Christian König 2017-08-31 18:39 ` Felix Kuehling 2017-08-31 19:00 ` Jerome Glisse [not found] ` <20170831190021.GG9227-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-31 23:19 ` Felix Kuehling 2017-08-31 23:29 ` Jerome Glisse 2017-08-30 0:11 ` Linus Torvalds 2017-11-30 9:33 ` BSOD with " Fabian Grünbichler 2017-11-30 9:33 ` Fabian Grünbichler 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 16:19 ` Radim Krčmář 2017-11-30 16:19 ` Radim Krčmář 2017-11-30 18:05 ` [PATCH 1/2] KVM: x86: fix APIC page invalidation Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář [this message] 2017-11-30 18:05 ` [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier Radim Krčmář 2017-12-01 15:15 ` Paolo Bonzini 2017-12-01 15:15 ` Paolo Bonzini 2017-12-01 15:15 ` Paolo Bonzini 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-01 12:21 ` [PATCH 1/2] KVM: x86: fix APIC page invalidation Fabian Grünbichler 2017-12-01 12:21 ` Fabian Grünbichler 2017-12-01 15:27 ` Paolo Bonzini 2017-12-01 15:27 ` Paolo Bonzini 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-06 2:32 ` Wanpeng Li 2017-12-06 2:32 ` Wanpeng Li 2017-12-06 9:50 ` 王金浦 2017-12-06 9:50 ` 王金浦 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-13 12:54 ` Richard Purdie 2017-12-13 12:54 ` Richard Purdie 2017-12-13 12:54 ` Richard Purdie 2017-11-30 16:19 ` BSOD with [PATCH 00/13] mmu_notifier kill invalidate_page callback Radim Krčmář 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 9:33 ` Fabian Grünbichler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171130180546.4331-2-rkrcmar@redhat.com \ --to=rkrcmar@redhat.com \ --cc=aarcange@redhat.com \ --cc=f.gruenbichler@proxmox.com \ --cc=jglisse@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.