All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 4/7] xfs: truncate transaction does not modify the inobt
Date: Thu, 30 Nov 2017 13:58:33 -0500	[thread overview]
Message-ID: <20171130185836.18481-5-bfoster@redhat.com> (raw)
In-Reply-To: <20171130185836.18481-1-bfoster@redhat.com>

The truncate transaction does not ever modify the inode btree, but
includes an associated log reservation. Update
xfs_calc_itruncate_reservation() to remove the reservation
associated with inobt updates.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 fs/xfs/libxfs/xfs_trans_resv.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
index 173b1bc13ffe..037a1295d289 100644
--- a/fs/xfs/libxfs/xfs_trans_resv.c
+++ b/fs/xfs/libxfs/xfs_trans_resv.c
@@ -232,8 +232,6 @@ xfs_calc_write_reservation(
  *    the super block to reflect the freed blocks: sector size
  *    worst case split in allocation btrees per extent assuming 4 extents:
  *		4 exts * 2 trees * (2 * max depth - 1) * block size
- *    the inode btree: max depth * blocksize
- *    the allocation btrees: 2 trees * (max depth - 1) * block size
  */
 STATIC uint
 xfs_calc_itruncate_reservation(
@@ -245,12 +243,7 @@ xfs_calc_itruncate_reservation(
 				      XFS_FSB_TO_B(mp, 1))),
 		    (xfs_calc_buf_res(9, mp->m_sb.sb_sectsize) +
 		     xfs_calc_buf_res(xfs_allocfree_log_count(mp, 4),
-				      XFS_FSB_TO_B(mp, 1)) +
-		    xfs_calc_buf_res(5, 0) +
-		    xfs_calc_buf_res(xfs_allocfree_log_count(mp, 1),
-				     XFS_FSB_TO_B(mp, 1)) +
-		    xfs_calc_buf_res(2 + mp->m_ialloc_blks +
-				     mp->m_in_maxlevels, 0)));
+				      XFS_FSB_TO_B(mp, 1))));
 }
 
 /*
-- 
2.13.6


  parent reply	other threads:[~2017-11-30 18:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 18:58 [PATCH v2 0/7] xfs: inode transaction reservation fixups Brian Foster
2017-11-30 18:58 ` [PATCH v2 1/7] xfs: print transaction log reservation on overrun Brian Foster
2017-12-07 21:34   ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 2/7] xfs: include inobt buffers in ifree tx log reservation Brian Foster
2017-12-03 21:44   ` Dave Chinner
2017-12-07 21:40   ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 3/7] xfs: fix up agi unlinked list reservations Brian Foster
2017-12-03 21:45   ` Dave Chinner
2017-12-07 21:41   ` Darrick J. Wong
2017-11-30 18:58 ` Brian Foster [this message]
2017-12-03 21:46   ` [PATCH v2 4/7] xfs: truncate transaction does not modify the inobt Dave Chinner
2017-12-07 21:44   ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 5/7] xfs: include an allocfree res for inobt modifications Brian Foster
2017-12-07 21:47   ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 6/7] xfs: refactor inode chunk alloc/free tx reservation Brian Foster
2017-12-03 21:52   ` Dave Chinner
2017-12-04 12:17     ` Brian Foster
2017-12-04 12:21   ` [PATCH v3 " Brian Foster
2017-12-07 21:53     ` Darrick J. Wong
2017-11-30 18:58 ` [PATCH v2 7/7] xfs: eliminate duplicate icreate tx reservation functions Brian Foster
2017-12-03 21:54   ` Dave Chinner
2017-12-07 21:57   ` Darrick J. Wong
2018-01-08 14:08 ` [PATCH v2 0/7] xfs: inode transaction reservation fixups Brian Foster
2018-01-08 18:06   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130185836.18481-5-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.