From: Christoph Hellwig <hch@lst.de> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>, linux-nvdimm@lists.01.org Subject: [PATCH 11/14] memremap: simplify duplicate region handling in devm_memremap_pages Date: Thu, 7 Dec 2017 07:08:37 -0800 [thread overview] Message-ID: <20171207150840.28409-12-hch@lst.de> (raw) In-Reply-To: <20171207150840.28409-1-hch@lst.de> __radix_tree_insert already checks for duplicates and returns -EEXIST in that case, so remove the duplicate (and racy) duplicates check. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/memremap.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index f4b198304e3b..4301fb657150 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -379,17 +379,6 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) align_end = align_start + align_size - 1; foreach_order_pgoff(res, order, pgoff) { - struct dev_pagemap *dup; - - rcu_read_lock(); - dup = find_dev_pagemap(res->start + PFN_PHYS(pgoff)); - rcu_read_unlock(); - if (dup) { - dev_err(dev, "%s: %pr collides with mapping for %s\n", - __func__, res, dev_name(dup->dev)); - error = -EBUSY; - break; - } error = __radix_tree_insert(&pgmap_radix, PHYS_PFN(res->start) + pgoff, order, pgmap); if (error) { -- 2.14.2 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Dan Williams <dan.j.williams@intel.com> Cc: "Jérôme Glisse" <jglisse@redhat.com>, "Logan Gunthorpe" <logang@deltatee.com>, linux-nvdimm@lists.01.org, linux-mm@kvack.org Subject: [PATCH 11/14] memremap: simplify duplicate region handling in devm_memremap_pages Date: Thu, 7 Dec 2017 07:08:37 -0800 [thread overview] Message-ID: <20171207150840.28409-12-hch@lst.de> (raw) In-Reply-To: <20171207150840.28409-1-hch@lst.de> __radix_tree_insert already checks for duplicates and returns -EEXIST in that case, so remove the duplicate (and racy) duplicates check. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/memremap.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index f4b198304e3b..4301fb657150 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -379,17 +379,6 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) align_end = align_start + align_size - 1; foreach_order_pgoff(res, order, pgoff) { - struct dev_pagemap *dup; - - rcu_read_lock(); - dup = find_dev_pagemap(res->start + PFN_PHYS(pgoff)); - rcu_read_unlock(); - if (dup) { - dev_err(dev, "%s: %pr collides with mapping for %s\n", - __func__, res, dev_name(dup->dev)); - error = -EBUSY; - break; - } error = __radix_tree_insert(&pgmap_radix, PHYS_PFN(res->start) + pgoff, order, pgmap); if (error) { -- 2.14.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-07 15:04 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-07 15:08 revamp vmem_altmap / dev_pagemap handling Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 15:08 ` [PATCH 01/14] mm: move get_dev_pagemap out of line Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:34 ` Logan Gunthorpe 2017-12-07 18:34 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 02/14] mm: optimize dev_pagemap reference counting around get_dev_pagemap Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:46 ` Logan Gunthorpe 2017-12-07 18:46 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 03/14] mm: better abstract out dev_pagemap freeing Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:49 ` Logan Gunthorpe 2017-12-07 18:49 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 04/14] mm: better abstract out dev_pagemap alloc Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:52 ` Logan Gunthorpe 2017-12-07 18:52 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 05/14] mm: better abstract out dev_pagemap offset calculation Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:54 ` Logan Gunthorpe 2017-12-07 18:54 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 06/14] mm: better abstract out dev_pagemap start_pfn Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 18:57 ` Logan Gunthorpe 2017-12-07 18:57 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 07/14] mm: split dev_pagemap memory map allocation from normal case Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 19:08 ` Logan Gunthorpe 2017-12-07 19:08 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 08/14] mm: merge vmem_altmap_alloc into dev_pagemap_alloc_block_buf Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 19:14 ` Logan Gunthorpe 2017-12-07 19:14 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 09/14] memremap: drop private struct page_map Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 15:08 ` [PATCH 10/14] memremap: change devm_memremap_pages interface to use struct dev_pagemap Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-08 4:03 ` Dan Williams 2017-12-07 15:08 ` Christoph Hellwig [this message] 2017-12-07 15:08 ` [PATCH 11/14] memremap: simplify duplicate region handling in devm_memremap_pages Christoph Hellwig 2017-12-07 19:34 ` Logan Gunthorpe 2017-12-07 19:34 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 12/14] memremap: remove find_dev_pagemap Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 19:35 ` Logan Gunthorpe 2017-12-07 19:35 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 13/14] memremap: remove struct vmem_altmap Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 19:40 ` Logan Gunthorpe 2017-12-07 19:40 ` Logan Gunthorpe 2017-12-07 15:08 ` [PATCH 14/14] memremap: RCU protect data returned from dev_pagemap lookups Christoph Hellwig 2017-12-07 15:08 ` Christoph Hellwig 2017-12-07 19:53 ` Logan Gunthorpe 2017-12-07 19:53 ` Logan Gunthorpe 2017-12-08 4:14 ` revamp vmem_altmap / dev_pagemap handling Williams, Dan J 2017-12-08 4:14 ` Williams, Dan J
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171207150840.28409-12-hch@lst.de \ --to=hch@lst.de \ --cc=dan.j.williams@intel.com \ --cc=jglisse@redhat.com \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.