All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org
Cc: marex@denx.de, david@lechnology.com, alison.wang@freescale.com,
	puck.chen@hisilicon.com, narmstrong@baylibre.com,
	abrodkin@synopsys.com, z.liuxinliang@hisilicon.com,
	kong.kongxinwei@hisilicon.com, laurent.pinchart@ideasonboard.com,
	daniel.vetter@ffwll.ch, zourongrong@gmail.com,
	liviu.dudau@arm.com
Subject: [PATCH v3 07/11] drm/rcar-du: Use drm_mode_config_helper_suspend/resume()
Date: Fri,  8 Dec 2017 20:37:39 +0100	[thread overview]
Message-ID: <20171208193743.34450-8-noralf@tronnes.org> (raw)
In-Reply-To: <20171208193743.34450-1-noralf@tronnes.org>

Replace driver's code with the generic helpers that do the same thing.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 +++------------------
 drivers/gpu/drm/rcar-du/rcar_du_drv.h |  1 -
 2 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 6e02c762a557..db040a64de45 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -22,10 +22,10 @@
 #include <linux/wait.h>
 
 #include <drm/drmP.h>
-#include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_fb_cma_helper.h>
 #include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_modeset_helper.h>
 
 #include "rcar_du_drv.h"
 #include "rcar_du_kms.h"
@@ -310,30 +310,15 @@ static struct drm_driver rcar_du_driver = {
 static int rcar_du_pm_suspend(struct device *dev)
 {
 	struct rcar_du_device *rcdu = dev_get_drvdata(dev);
-	struct drm_atomic_state *state;
 
-	drm_kms_helper_poll_disable(rcdu->ddev);
-	drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, true);
-
-	state = drm_atomic_helper_suspend(rcdu->ddev);
-	if (IS_ERR(state)) {
-		drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false);
-		drm_kms_helper_poll_enable(rcdu->ddev);
-		return PTR_ERR(state);
-	}
-
-	rcdu->suspend_state = state;
-
-	return 0;
+	return drm_mode_config_helper_suspend(rcdu->ddev);
 }
 
 static int rcar_du_pm_resume(struct device *dev)
 {
 	struct rcar_du_device *rcdu = dev_get_drvdata(dev);
 
-	drm_atomic_helper_resume(rcdu->ddev, rcdu->suspend_state);
-	drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false);
-	drm_kms_helper_poll_enable(rcdu->ddev);
+	drm_mode_config_helper_resume(rcdu->ddev);
 
 	return 0;
 }
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
index f400fde65a0c..f8cd79488ece 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
@@ -81,7 +81,6 @@ struct rcar_du_device {
 
 	struct drm_device *ddev;
 	struct drm_fbdev_cma *fbdev;
-	struct drm_atomic_state *suspend_state;
 
 	struct rcar_du_crtc crtcs[RCAR_DU_MAX_CRTCS];
 	unsigned int num_crtcs;
-- 
2.14.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-12-08 19:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 19:37 [PATCH v3 00/11] drm/cma-helper: Remove drm_fbdev_cma* functions Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 01/11] drm/arc: Use drm_fb_cma_fbdev_init/fini() Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 02/11] drm/arm/hdlcd: Use drm_mode_config_helper_suspend/resume() Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 03/11] drm/arm/hdlcd: Use drm_fb_cma_fbdev_init/fini() Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 04/11] drm/hisilicon/kirin: " Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 05/11] drm/meson: " Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 06/11] drm/mxsfb: " Noralf Trønnes
2017-12-08 19:37 ` Noralf Trønnes [this message]
2017-12-08 19:37 ` [PATCH v3 08/11] drm/rcar-du: " Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 09/11] drm/fsl-dcu: " Noralf Trønnes
2018-09-26 20:26   ` Stefan Agner
2018-09-27 12:23     ` Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 10/11] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini() Noralf Trønnes
2017-12-08 21:34   ` David Lechner
2017-12-10 14:41     ` Noralf Trønnes
2017-12-08 19:37 ` [PATCH v3 11/11] drm/cma-helper: Remove drm_fbdev_cma* functions Noralf Trønnes
2018-09-27 12:44 ` [PATCH v3 00/11] " Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208193743.34450-8-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=abrodkin@synopsys.com \
    --cc=alison.wang@freescale.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=david@lechnology.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=liviu.dudau@arm.com \
    --cc=marex@denx.de \
    --cc=narmstrong@baylibre.com \
    --cc=puck.chen@hisilicon.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.