All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 2/5] drm/print: Unconfuse kerneldoc
Date: Thu, 14 Dec 2017 21:30:51 +0100	[thread overview]
Message-ID: <20171214203054.20141-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20171214203054.20141-1-daniel.vetter@ffwll.ch>

It thinks we want to document the __printf(2,0) annotion. Not sure we
want to teach it about all possible gcc-only flags, hence why I opted
for the cheap trick of just moving it ahead of the kerneldoc.

This is only a problem for static inline functions, since for
non-inline function the kerneldoc is in the .c file, but the special
annotations are all in the header.

Cc'ing kernel-doc maintainers as fyi.

Cc: linux-doc@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_print.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 5f9932e2246e..2a4a42e59a47 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -80,13 +80,13 @@ void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf);
 __printf(2, 3)
 void drm_printf(struct drm_printer *p, const char *f, ...);
 
+__printf(2, 0)
 /**
  * drm_vprintf - print to a &drm_printer stream
  * @p: the &drm_printer
  * @fmt: format string
  * @va: the va_list
  */
-__printf(2, 0)
 static inline void
 drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)
 {
-- 
2.15.1


  parent reply	other threads:[~2017-12-14 20:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 20:30 [PATCH 0/5] bunch of drm kernel-doc patches Daniel Vetter
2017-12-14 20:30 ` [PATCH 1/5] drm/edid: kerneldoc for is_hdmi2_sink Daniel Vetter
2017-12-15  1:59   ` Alex Deucher
2017-12-14 20:30 ` Daniel Vetter [this message]
2017-12-15  2:00   ` [PATCH 2/5] drm/print: Unconfuse kerneldoc Alex Deucher
2017-12-14 20:30 ` [PATCH 3/5] drm/syncobj: some kerneldoc polish Daniel Vetter
2017-12-15  2:06   ` Alex Deucher
2017-12-14 20:30 ` [PATCH 4/5] drm/atomic: document how to handle driver private objects Daniel Vetter
2017-12-15  1:57   ` Alex Deucher
2017-12-18 16:09     ` Laurent Pinchart
2017-12-19 10:00       ` Daniel Vetter
2017-12-15  2:17   ` [Intel-gfx] " Pandiyan, Dhinakaran
2017-12-18 16:13   ` Laurent Pinchart
2017-12-19 10:03     ` Daniel Vetter
2017-12-19 13:33       ` Laurent Pinchart
2017-12-19 14:00         ` Daniel Vetter
2017-12-19 14:08           ` Laurent Pinchart
2017-12-14 20:30 ` [PATCH 5/5] drm/doc: Move legacy kms helpers to the very end Daniel Vetter
2017-12-15  2:11   ` Alex Deucher
2017-12-15 10:27     ` Daniel Vetter
2017-12-14 20:57 ` ✓ Fi.CI.BAT: success for bunch of drm kernel-doc patches Patchwork
2017-12-14 22:21 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214203054.20141-3-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=corbet@lwn.net \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-doc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.