From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>,
linux-rockchip@lists.infradead.org
Subject: [PATCH] PCI: rockchip: Remove redundant "valid device" check
Date: Fri, 15 Dec 2017 14:29:35 -0600 [thread overview]
Message-ID: <20171215202935.157396.74423.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
In rockchip_pcie_valid_device(), we do the exact same test twice:
if (bus->number == rockchip->root_bus_nr && dev > 0)
return 0;
if (bus->number == rockchip->root_bus_nr && dev > 0)
return 0;
We only need to do it once, so remove one of them.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/pcie-rockchip.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 9051c6c8fea4..dd9c7ea69e0b 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -293,10 +293,6 @@ static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockchip)
static int rockchip_pcie_valid_device(struct rockchip_pcie *rockchip,
struct pci_bus *bus, int dev)
{
- /* access only one slot on each root port */
- if (bus->number == rockchip->root_bus_nr && dev > 0)
- return 0;
-
/*
* do not read more than one device on the bus directly attached
* to RC's downstream side.
next reply other threads:[~2017-12-15 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 20:29 Bjorn Helgaas [this message]
2018-09-17 14:47 ` [PATCH] PCI: rockchip: Remove redundant "valid device" check Lorenzo Pieralisi
2018-09-17 14:47 ` Lorenzo Pieralisi
2018-09-17 17:12 ` Bjorn Helgaas
2018-09-17 17:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215202935.157396.74423.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.