All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	cphealy@gmail.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 13/22] nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()
Date: Wed,  3 Jan 2018 12:01:05 -0800	[thread overview]
Message-ID: <20180103200114.23922-14-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180103200114.23922-1-andrew.smirnov@gmail.com>

Drop all of the code related to .remove hook and make use of
devm_nvmem_register() instead.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy@gmail.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/lpc18xx_otp.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/nvmem/lpc18xx_otp.c b/drivers/nvmem/lpc18xx_otp.c
index 95268db155e9..74777bfe2dcd 100644
--- a/drivers/nvmem/lpc18xx_otp.c
+++ b/drivers/nvmem/lpc18xx_otp.c
@@ -86,22 +86,13 @@ static int lpc18xx_otp_probe(struct platform_device *pdev)
 	lpc18xx_otp_nvmem_config.dev = &pdev->dev;
 	lpc18xx_otp_nvmem_config.priv = otp;
 
-	nvmem = nvmem_register(&lpc18xx_otp_nvmem_config);
+	nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config);
 	if (IS_ERR(nvmem))
 		return PTR_ERR(nvmem);
 
-	platform_set_drvdata(pdev, nvmem);
-
 	return 0;
 }
 
-static int lpc18xx_otp_remove(struct platform_device *pdev)
-{
-	struct nvmem_device *nvmem = platform_get_drvdata(pdev);
-
-	return nvmem_unregister(nvmem);
-}
-
 static const struct of_device_id lpc18xx_otp_dt_ids[] = {
 	{ .compatible = "nxp,lpc1850-otp" },
 	{ },
@@ -110,7 +101,6 @@ MODULE_DEVICE_TABLE(of, lpc18xx_otp_dt_ids);
 
 static struct platform_driver lpc18xx_otp_driver = {
 	.probe	= lpc18xx_otp_probe,
-	.remove	= lpc18xx_otp_remove,
 	.driver = {
 		.name	= "lpc18xx_otp",
 		.of_match_table = lpc18xx_otp_dt_ids,
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: andrew.smirnov@gmail.com (Andrey Smirnov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 13/22] nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()
Date: Wed,  3 Jan 2018 12:01:05 -0800	[thread overview]
Message-ID: <20180103200114.23922-14-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180103200114.23922-1-andrew.smirnov@gmail.com>

Drop all of the code related to .remove hook and make use of
devm_nvmem_register() instead.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy at gmail.com
Cc: linux-kernel at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/lpc18xx_otp.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/nvmem/lpc18xx_otp.c b/drivers/nvmem/lpc18xx_otp.c
index 95268db155e9..74777bfe2dcd 100644
--- a/drivers/nvmem/lpc18xx_otp.c
+++ b/drivers/nvmem/lpc18xx_otp.c
@@ -86,22 +86,13 @@ static int lpc18xx_otp_probe(struct platform_device *pdev)
 	lpc18xx_otp_nvmem_config.dev = &pdev->dev;
 	lpc18xx_otp_nvmem_config.priv = otp;
 
-	nvmem = nvmem_register(&lpc18xx_otp_nvmem_config);
+	nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config);
 	if (IS_ERR(nvmem))
 		return PTR_ERR(nvmem);
 
-	platform_set_drvdata(pdev, nvmem);
-
 	return 0;
 }
 
-static int lpc18xx_otp_remove(struct platform_device *pdev)
-{
-	struct nvmem_device *nvmem = platform_get_drvdata(pdev);
-
-	return nvmem_unregister(nvmem);
-}
-
 static const struct of_device_id lpc18xx_otp_dt_ids[] = {
 	{ .compatible = "nxp,lpc1850-otp" },
 	{ },
@@ -110,7 +101,6 @@ MODULE_DEVICE_TABLE(of, lpc18xx_otp_dt_ids);
 
 static struct platform_driver lpc18xx_otp_driver = {
 	.probe	= lpc18xx_otp_probe,
-	.remove	= lpc18xx_otp_remove,
 	.driver = {
 		.name	= "lpc18xx_otp",
 		.of_match_table = lpc18xx_otp_dt_ids,
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: andrew.smirnov@gmail.com (Andrey Smirnov)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 13/22] nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()
Date: Wed,  3 Jan 2018 12:01:05 -0800	[thread overview]
Message-ID: <20180103200114.23922-14-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180103200114.23922-1-andrew.smirnov@gmail.com>

Drop all of the code related to .remove hook and make use of
devm_nvmem_register() instead.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy at gmail.com
Cc: linux-kernel at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/lpc18xx_otp.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/nvmem/lpc18xx_otp.c b/drivers/nvmem/lpc18xx_otp.c
index 95268db155e9..74777bfe2dcd 100644
--- a/drivers/nvmem/lpc18xx_otp.c
+++ b/drivers/nvmem/lpc18xx_otp.c
@@ -86,22 +86,13 @@ static int lpc18xx_otp_probe(struct platform_device *pdev)
 	lpc18xx_otp_nvmem_config.dev = &pdev->dev;
 	lpc18xx_otp_nvmem_config.priv = otp;
 
-	nvmem = nvmem_register(&lpc18xx_otp_nvmem_config);
+	nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config);
 	if (IS_ERR(nvmem))
 		return PTR_ERR(nvmem);
 
-	platform_set_drvdata(pdev, nvmem);
-
 	return 0;
 }
 
-static int lpc18xx_otp_remove(struct platform_device *pdev)
-{
-	struct nvmem_device *nvmem = platform_get_drvdata(pdev);
-
-	return nvmem_unregister(nvmem);
-}
-
 static const struct of_device_id lpc18xx_otp_dt_ids[] = {
 	{ .compatible = "nxp,lpc1850-otp" },
 	{ },
@@ -110,7 +101,6 @@ MODULE_DEVICE_TABLE(of, lpc18xx_otp_dt_ids);
 
 static struct platform_driver lpc18xx_otp_driver = {
 	.probe	= lpc18xx_otp_probe,
-	.remove	= lpc18xx_otp_remove,
 	.driver = {
 		.name	= "lpc18xx_otp",
 		.of_match_table = lpc18xx_otp_dt_ids,
-- 
2.14.3

  parent reply	other threads:[~2018-01-03 20:01 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 20:00 [PATCH v3 00/22] Verbatim device names and devm_nvmem_(un)register() Andrey Smirnov
2018-01-03 20:00 ` Andrey Smirnov
2018-01-03 20:00 ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 01/22] nvmem: Document struct nvmem_config Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-02-28 18:34   ` Sean Wang
2018-02-28 18:34     ` Sean Wang
2018-02-28 18:34     ` Sean Wang
2018-02-28 18:34     ` Sean Wang
2018-03-08 18:22     ` Andrey Smirnov
2018-03-08 18:22       ` Andrey Smirnov
2018-03-08 18:22       ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 02/22] nvmem: core: Allow specifying device name verbatim Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 03/22] nvmem: Introduce devm_nvmem_(un)register() Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 04/22] nvmem: vf610-ocotp: Convert to use devm_nvmem_register() Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 05/22] nvmem: imx-ocotp: " Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 06/22] nvmem: uniphier-efuse: " Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 07/22] nvmem: snvs_lgpr: " Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:00   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 08/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 09/22] nvmem: qfprom: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 10/22] nvmem: mtk-efuse: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 11/22] nvmem: meson-mx-efuse: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 12/22] nvmem: meson-efuse: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` Andrey Smirnov [this message]
2018-01-03 20:01   ` [PATCH v3 13/22] nvmem: lpc18xx_otp: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 14/22] nvmem: imx-iim: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 15/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 17/22] nvmem: snvs_lpgpr: Convert commas to semicolons Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 18/22] nvmem: rockchip-efuse: Make use of of_device_get_match_data() Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 19/22] nvmem: vf610-ocotp: Do not use "&pdev->dev" explicitly Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 20/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 21/22] nvmem: imx-iim: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 22/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-03 20:01   ` Andrey Smirnov
2018-01-24 11:13 ` [PATCH v3 00/22] Verbatim device names and devm_nvmem_(un)register() Bartosz Golaszewski
2018-01-24 11:13   ` Bartosz Golaszewski
2018-01-24 11:13   ` Bartosz Golaszewski
2018-01-25  9:17   ` Srinivas Kandagatla
2018-01-25  9:17     ` Srinivas Kandagatla
2018-01-25  9:17     ` Srinivas Kandagatla
2018-01-25  9:17     ` Srinivas Kandagatla
2018-02-26  3:45     ` Andrey Smirnov
2018-02-26  3:45       ` Andrey Smirnov
2018-02-26  3:45       ` Andrey Smirnov
2018-02-26  9:30       ` Srinivas Kandagatla
2018-02-26  9:30         ` Srinivas Kandagatla
2018-02-26  9:30         ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103200114.23922-14-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=carlo@caione.org \
    --cc=cphealy@gmail.com \
    --cc=heiko@sntech.de \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.