All of lore.kernel.org
 help / color / mirror / Atom feed
From: Su Yue <suy.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <suy.fnst@cn.fujitsu.com>
Subject: [PATCH v3 03/17] btrfs-progs: lowmem check: assign @parent early in repair_extent_data_item()
Date: Thu, 11 Jan 2018 15:34:57 +0800	[thread overview]
Message-ID: <20180111073511.25288-4-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20180111073511.25288-1-suy.fnst@cn.fujitsu.com>

The variable @eb is assigned to leaf in fs_tree before insertion of
backref. It will causes wrong parent of new inserted backref.

Set @parent in the begin solves the problem.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
 cmds-check.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/cmds-check.c b/cmds-check.c
index 4743a19421ec..24fb4bc50b95 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -11944,6 +11944,11 @@ static int repair_extent_data_item(struct btrfs_trans_handle *trans,
 	extent_offset = btrfs_file_extent_offset(eb, fi);
 	offset = file_offset - extent_offset;
 
+	if (nrefs->full_backref[0])
+		parent = btrfs_header_bytenr(eb);
+	else
+		parent = 0;
+
 	/* now repair only adds backref */
 	if ((err & BACKREF_MISSING) == 0)
 		return err;
@@ -11985,11 +11990,6 @@ static int repair_extent_data_item(struct btrfs_trans_handle *trans,
 		btrfs_release_path(&path);
 	}
 
-	if (nrefs->full_backref[0])
-		parent = btrfs_header_bytenr(eb);
-	else
-		parent = 0;
-
 	ret = btrfs_inc_extent_ref(trans, root, disk_bytenr, num_bytes, parent,
 				   root->objectid,
 		   parent ? BTRFS_FIRST_FREE_OBJECTID : fi_key.objectid,
-- 
2.15.1




  parent reply	other threads:[~2018-01-11  7:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  7:34 [PATCH v3 00/17] btrfs-progs: lowmem check: avoid extents overwrite Su Yue
2018-01-11  7:34 ` [PATCH v3 01/17] btrfs-progs: lowmem check: release path in repair_extent_data_item() Su Yue
2018-01-11  7:34 ` [PATCH v3 02/17] btrfs-progs: lowmem check: record returned errors after walk_down_tree_v2() Su Yue
2018-01-11  7:34 ` Su Yue [this message]
2018-01-11  7:34 ` [PATCH v3 04/17] btrfs-progs: lowmem check: exclude extents of metadata blocks Su Yue
2018-01-11  7:34 ` [PATCH v3 05/17] btrfs-progs: lowmem check: introduce mark/clear_block_groups_full() Su Yue
2018-01-11  7:35 ` [PATCH v3 06/17] btrfs-progs: lowmem check: introduce force_cow_in_new_chunk() Su Yue
2018-01-11  7:35 ` [PATCH v3 07/17] btrfs-progs: lowmem check: introduce try_avoid_extents_overwrite() Su Yue
2018-01-11  7:35 ` [PATCH v3 08/17] btrfs-progs: lowmem check: exclude extents if init-extent-tree in lowmem Su Yue
2018-01-11  7:35 ` [PATCH v3 09/17] btrfs-progs: lowmem check: start to remove parameters @trans " Su Yue
2018-01-11  7:35 ` [PATCH v3 10/17] btrfs-progs: lowmem check: remove parameter @trans of delete_extent_item() Su Yue
2018-01-11  7:35 ` [PATCH v3 11/17] btrfs-progs: lowmem check: remove parameter @trans of repair_chunk_item() Su Yue
2018-01-11  7:35 ` [PATCH v3 12/17] btrfs-progs: lowmem check: remove parameter @trans of repair_extent_item() Su Yue
2018-01-11  7:35 ` [PATCH v3 13/17] btrfs-progs: lowmem check: remove parameter @trans of check_leaf_items() Su Yue
2018-01-11  7:35 ` [PATCH v3 14/17] btrfs-progs: lowmem check: remove parameter @trans of repair_tree_back_ref() Su Yue
2018-01-11  7:35 ` [PATCH v3 15/17] btrfs-progs: lowmem check: remove parameter @trans of check_btrfs_root() Su Yue
2018-01-11  7:35 ` [PATCH v3 16/17] btrfs-progs: lowmem check: introduce repair_block_accounting() Su Yue
2018-01-11  7:35 ` [PATCH v3 17/17] btrfs-progs: lowmem check: end of removing parameters @trans in lowmem Su Yue
2018-01-29  6:01 ` [PATCH v3 00/17] btrfs-progs: lowmem check: avoid extents overwrite Su Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111073511.25288-4-suy.fnst@cn.fujitsu.com \
    --to=suy.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.