All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>, dm-devel@redhat.com
Cc: Martin Wilck <mwilck@suse.com>
Subject: [PATCH 09/14] libmultipath: select ALUA prioritizer for RDAC arrays only
Date: Fri, 12 Jan 2018 23:07:38 +0100	[thread overview]
Message-ID: <20180112220743.11513-10-mwilck@suse.com> (raw)
In-Reply-To: <20180112220743.11513-1-mwilck@suse.com>

Since commit 7e2f46d3, multipathd with "detect_prio" setting (=default)
chooses ALUA prioritizer rather than sysfs prioritizer for arrays with
implicit TPGS. But the intention of that patch was to choose ALUA for
NetApp E-Series (RDAC) storage arrays *only*, not for every array
with implicit TPGS.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 libmultipath/propsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index d08954ac8464..4dba4c50beb9 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -497,7 +497,7 @@ detect_prio(struct config *conf, struct path * pp)
 
 	if (pp->tpgs <= 0)
 		return;
-	if (pp->tpgs == 2 && !check_rdac(pp)) {
+	if (pp->tpgs == 2 || !check_rdac(pp)) {
 		if (sysfs_get_asymmetric_access_state(pp, buff, 512) >= 0)
 			default_prio = PRIO_SYSFS;
 	}
-- 
2.15.1

  parent reply	other threads:[~2018-01-12 22:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 22:07 [PATCH 00/14] Various multipath-tools fixes Martin Wilck
2018-01-12 22:07 ` [PATCH 01/14] multipathd daemon: Fix incorrect use of CLOCK_MONOTONIC in pthread Martin Wilck
2018-01-12 22:07 ` [PATCH 02/14] libmultipath: don't try to set hwhandler if it is retained Martin Wilck
2018-01-12 22:07 ` [PATCH 03/14] multipath: delegate dangerous commands to multipathd Martin Wilck
2018-01-12 22:07 ` [PATCH 04/14] libmultipath: condlog: log to stderr Martin Wilck
2018-01-12 22:07 ` [PATCH 05/14] libmultipath: fix return code of sysfs_get_timeout Martin Wilck
2018-01-12 22:07 ` [PATCH 06/14] libmultipath: fix return code of sgio_get_vpd() Martin Wilck
2018-01-12 22:07 ` [PATCH 07/14] libmultipath: sgio_get_vpd: add page argument Martin Wilck
2018-01-12 22:07 ` [PATCH 08/14] libmultipath: get_vpd_sgio: support VPD 0xc9 Martin Wilck
2018-01-12 22:07 ` Martin Wilck [this message]
2018-01-12 22:07 ` [PATCH 10/14] libmultipath: hwtable: multibus for NetApp NVMe-FC Martin Wilck
2018-01-12 23:42   ` Xose Vazquez Perez
2018-01-13 13:03     ` Martin Wilck
2018-01-12 22:07 ` [PATCH 11/14] multipath -C: decrease log level Martin Wilck
2018-01-12 22:07 ` [PATCH 12/14] kpartx.rules: fix by-id/scsi-* for user_friendly_names Martin Wilck
2018-01-12 22:07 ` [PATCH 13/14] multipathd.socket: add WantedBy=sockets.target Martin Wilck
2018-01-12 22:07 ` [PATCH 14/14] multipathd.service: drop Before=lvm2-lvmetad.service Martin Wilck
2018-01-12 23:52 ` [PATCH 00/14] Various multipath-tools fixes Xose Vazquez Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180112220743.11513-10-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.