From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] btrfs-progs: fsck: Continue check even if we find space cache problem
Date: Mon, 15 Jan 2018 12:27:22 +0800 [thread overview]
Message-ID: <20180115042722.25435-1-wqu@suse.com> (raw)
Space cache itself is not a fatal part of btrfs (especially for v1 space
cache), and if we find something wrong it can be caused by other more
serious problem.
So continue to check more important trees even we found something wrong
in free space cache.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
cmds-check.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cmds-check.c b/cmds-check.c
index 7fc30da83ea1..6083ac0dd032 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -15000,7 +15000,10 @@ int cmd_check(int argc, char **argv)
error("errors found in free space tree");
else
error("errors found in free space cache");
- goto out;
+ /*
+ * Space cache problem is not fatal, and normally indicates more
+ * serious problem, so continue check to expose the cause.
+ */
}
/*
--
2.15.1
reply other threads:[~2018-01-15 4:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115042722.25435-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.