All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Oleksandr Natalenko <oleksandr@natalenko.name>,
	Jonathan Buzzard <jonathan@buzzard.org.uk>,
	Mario Limonciello <mario.limonciello@dell.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: [PATCH 1/4] hwmon: (dell-smm) Enable broken functionality via "force" module param
Date: Sat, 27 Jan 2018 17:22:01 +0100	[thread overview]
Message-ID: <20180127162204.13752-2-pali.rohar@gmail.com> (raw)
In-Reply-To: <20180127162204.13752-1-pali.rohar@gmail.com>

Some Dell machines are broken and some functionality is disabled. Show
warning into dmesg about this fact and allow user via "force" module param
to override brokenness and enable broken functionality.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index c7c9e95e58a8..aef4f8317ae2 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1060,8 +1060,11 @@ static int __init i8k_probe(void)
 			i8k_get_dmi_data(DMI_BIOS_VERSION));
 	}
 
-	if (dmi_check_system(i8k_blacklist_fan_type_dmi_table))
-		disallow_fan_type_call = true;
+	if (dmi_check_system(i8k_blacklist_fan_type_dmi_table)) {
+		pr_warn("broken Dell BIOS detected, disallow fan type call\n");
+		if (!force)
+			disallow_fan_type_call = true;
+	}
 
 	strlcpy(bios_version, i8k_get_dmi_data(DMI_BIOS_VERSION),
 		sizeof(bios_version));
-- 
2.11.0


  reply	other threads:[~2018-01-27 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-27 16:22 [PATCH 0/4] hwmon: (dell-smm) Disable fan support on Inspiron 7720 and Vostro 3360 Pali Rohár
2018-01-27 16:22 ` Pali Rohár [this message]
2018-01-27 16:23 ` [PATCH 3/4] hwmon: (dell-smm) Disable fan support for Dell " Pali Rohár
2018-01-27 16:23 ` [PATCH 4/4] hwmon: (dell-smm) Measure time duration of SMM call around inlined asm Pali Rohár
2018-01-27 17:51   ` [4/4] " Guenter Roeck
2018-01-29  8:46     ` Pali Rohár
2018-01-27 16:28 ` [PATCH 2/4] hwmon: (dell-smm) Disable fan support for Dell Inspiron 7720 Pali Rohár
2018-01-27 16:33 ` [PATCH 0/4] hwmon: (dell-smm) Disable fan support on Inspiron 7720 and Vostro 3360 Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180127162204.13752-2-pali.rohar@gmail.com \
    --to=pali.rohar@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=jonathan@buzzard.org.uk \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mario.limonciello@dell.com \
    --cc=oleksandr@natalenko.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.