All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH] ndctl: remove a double put in injection status json
Date: Wed, 31 Jan 2018 17:49:38 -0700	[thread overview]
Message-ID: <20180201004938.19823-1-vishal.l.verma@intel.com> (raw)

newer json-c catches a double put of the json object in printing the
injection status. We only need to put the containing jobj.

Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/inject-error.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ndctl/inject-error.c b/ndctl/inject-error.c
index 374ae0b..9b9d821 100644
--- a/ndctl/inject-error.c
+++ b/ndctl/inject-error.c
@@ -263,8 +263,6 @@ static int injection_status(struct ndctl_namespace *ndns)
 		printf("%s\n", json_object_to_json_string_ext(jobj,
 			JSON_C_TO_STRING_PRETTY));
 	}
-
-	json_object_put(jbbs);
 	json_object_put(jobj);
 
 	return rc;
-- 
2.14.3

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

             reply	other threads:[~2018-02-01  0:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01  0:49 Vishal Verma [this message]
2018-02-01  0:57 ` [ndctl PATCH] ndctl: remove a double put in injection status json Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180201004938.19823-1-vishal.l.verma@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.