From: Vinod Koul <vinod.koul@intel.com>
To: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Cc: Jassi Brar <jaswinder.singh@linaro.org>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v2 1/3] cplay: add option to specify codec ID
Date: Fri, 2 Feb 2018 23:06:16 +0530 [thread overview]
Message-ID: <20180202173616.GI18649@localhost> (raw)
In-Reply-To: <20180202043246.10481-1-suzuki.katsuhiro@socionext.com>
On Fri, Feb 02, 2018 at 01:32:44PM +0900, Katsuhiro Suzuki wrote:
> This patch adds a -I command line option to set the codec ID,
> same as crecord.
Applied all 3 patches with below nit fix, thanks
diff --git a/src/utils/cplay.c b/src/utils/cplay.c
index f15c72876fb0..98d71a2199da 100644
--- a/src/utils/cplay.c
+++ b/src/utils/cplay.c
@@ -304,7 +304,7 @@ void get_codec_mp3(FILE *file, struct compr_config *config,
codec->format = 0;
}
-int get_codec_iec(FILE *file, struct compr_config *config,
+void get_codec_iec(FILE *file, struct compr_config *config,
struct snd_codec *codec)
{
codec->id = SND_AUDIOCODEC_IEC61937;
--
~Vinod
prev parent reply other threads:[~2018-02-02 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 4:32 [PATCH v2 1/3] cplay: add option to specify codec ID Katsuhiro Suzuki
2018-02-02 4:32 ` [PATCH v2 2/3] cplay: move around MP3 header parsing method Katsuhiro Suzuki
2018-02-02 4:32 ` [PATCH v2 3/3] cplay: support IEC61937 format Katsuhiro Suzuki
2018-02-02 17:36 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202173616.GI18649@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=jaswinder.singh@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=suzuki.katsuhiro@socionext.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.