From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Barry Song <baohua@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Marcus Folkesson <marcus.folkesson@gmail.com>
Subject: [PATCH v2 7/7] watchdog: coh901327: make use of timeout-secs provided in devicetree
Date: Sat, 10 Feb 2018 10:19:11 +0100 [thread overview]
Message-ID: <20180210091911.3644-7-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <20180210091911.3644-1-marcus.folkesson@gmail.com>
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
v2:
- Set .timeout in coh901327_wdt structure declaration.
- Set .min_timeout to 1 instead of 0. I could not find a datasheet
for coh901327, so I'm not sure if 0 is valid. However, 0 seems
wrong to me and most driver has 1 as min value. If it should
be 0, please let me know and I have to set another initial
value for margin.
drivers/watchdog/coh901327_wdt.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index 4410337f4f7f..5d8eb9a30879 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -67,7 +67,9 @@
#define U300_WDOG_IFR_WILL_BARK_IRQ_FORCE_ENABLE 0x0001U
/* Default timeout in seconds = 1 minute */
-static unsigned int margin = 60;
+#define U300_WDOG_DEFAULT_TIMEOUT 60
+
+static unsigned int margin;
static int irq;
static void __iomem *virtbase;
static struct device *parent;
@@ -235,8 +237,9 @@ static struct watchdog_device coh901327_wdt = {
* timeout register is max
* 0x7FFF = 327670ms ~= 327s.
*/
- .min_timeout = 0,
+ .min_timeout = 1,
.max_timeout = 327,
+ .timeout = U300_WDOG_DEFAULT_TIMEOUT,
};
static int __exit coh901327_remove(struct platform_device *pdev)
@@ -315,9 +318,7 @@ static int __init coh901327_probe(struct platform_device *pdev)
goto out_no_irq;
}
- ret = watchdog_init_timeout(&coh901327_wdt, margin, dev);
- if (ret < 0)
- coh901327_wdt.timeout = 60;
+ watchdog_init_timeout(&coh901327_wdt, margin, dev);
coh901327_wdt.parent = dev;
ret = watchdog_register_device(&coh901327_wdt);
--
2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] watchdog: coh901327: make use of timeout-secs provided in devicetree
Date: Sat, 10 Feb 2018 10:19:11 +0100 [thread overview]
Message-ID: <20180210091911.3644-7-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <20180210091911.3644-1-marcus.folkesson@gmail.com>
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
v2:
- Set .timeout in coh901327_wdt structure declaration.
- Set .min_timeout to 1 instead of 0. I could not find a datasheet
for coh901327, so I'm not sure if 0 is valid. However, 0 seems
wrong to me and most driver has 1 as min value. If it should
be 0, please let me know and I have to set another initial
value for margin.
drivers/watchdog/coh901327_wdt.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index 4410337f4f7f..5d8eb9a30879 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -67,7 +67,9 @@
#define U300_WDOG_IFR_WILL_BARK_IRQ_FORCE_ENABLE 0x0001U
/* Default timeout in seconds = 1 minute */
-static unsigned int margin = 60;
+#define U300_WDOG_DEFAULT_TIMEOUT 60
+
+static unsigned int margin;
static int irq;
static void __iomem *virtbase;
static struct device *parent;
@@ -235,8 +237,9 @@ static struct watchdog_device coh901327_wdt = {
* timeout register is max
* 0x7FFF = 327670ms ~= 327s.
*/
- .min_timeout = 0,
+ .min_timeout = 1,
.max_timeout = 327,
+ .timeout = U300_WDOG_DEFAULT_TIMEOUT,
};
static int __exit coh901327_remove(struct platform_device *pdev)
@@ -315,9 +318,7 @@ static int __init coh901327_probe(struct platform_device *pdev)
goto out_no_irq;
}
- ret = watchdog_init_timeout(&coh901327_wdt, margin, dev);
- if (ret < 0)
- coh901327_wdt.timeout = 60;
+ watchdog_init_timeout(&coh901327_wdt, margin, dev);
coh901327_wdt.parent = dev;
ret = watchdog_register_device(&coh901327_wdt);
--
2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 7/7] watchdog: coh901327: make use of timeout-secs provided in devicetree
Date: Sat, 10 Feb 2018 10:19:11 +0100 [thread overview]
Message-ID: <20180210091911.3644-7-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <20180210091911.3644-1-marcus.folkesson@gmail.com>
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
v2:
- Set .timeout in coh901327_wdt structure declaration.
- Set .min_timeout to 1 instead of 0. I could not find a datasheet
for coh901327, so I'm not sure if 0 is valid. However, 0 seems
wrong to me and most driver has 1 as min value. If it should
be 0, please let me know and I have to set another initial
value for margin.
drivers/watchdog/coh901327_wdt.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index 4410337f4f7f..5d8eb9a30879 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -67,7 +67,9 @@
#define U300_WDOG_IFR_WILL_BARK_IRQ_FORCE_ENABLE 0x0001U
/* Default timeout in seconds = 1 minute */
-static unsigned int margin = 60;
+#define U300_WDOG_DEFAULT_TIMEOUT 60
+
+static unsigned int margin;
static int irq;
static void __iomem *virtbase;
static struct device *parent;
@@ -235,8 +237,9 @@ static struct watchdog_device coh901327_wdt = {
* timeout register is max
* 0x7FFF = 327670ms ~= 327s.
*/
- .min_timeout = 0,
+ .min_timeout = 1,
.max_timeout = 327,
+ .timeout = U300_WDOG_DEFAULT_TIMEOUT,
};
static int __exit coh901327_remove(struct platform_device *pdev)
@@ -315,9 +318,7 @@ static int __init coh901327_probe(struct platform_device *pdev)
goto out_no_irq;
}
- ret = watchdog_init_timeout(&coh901327_wdt, margin, dev);
- if (ret < 0)
- coh901327_wdt.timeout = 60;
+ watchdog_init_timeout(&coh901327_wdt, margin, dev);
coh901327_wdt.parent = dev;
ret = watchdog_register_device(&coh901327_wdt);
--
2.15.1
next prev parent reply other threads:[~2018-02-10 9:19 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 9:19 [PATCH v2 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` [PATCH v2 2/7] watchdog: sunxi: allow setting timeout " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` [PATCH v2 3/7] watchdog: sirfsoc: " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` [PATCH v2 4/7] watchdog: pnx4008: make use of timeout-secs provided " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` [PATCH v2 5/7] watchdog: mtk: allow setting timeout " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 11:10 ` Sean Wang
2018-02-10 11:10 ` Sean Wang
2018-02-10 11:10 ` Sean Wang
2018-02-10 11:10 ` Sean Wang
2018-02-10 12:43 ` Marcus Folkesson
2018-02-10 12:43 ` Marcus Folkesson
2018-02-10 12:43 ` Marcus Folkesson
2018-02-10 12:43 ` Marcus Folkesson
2018-02-10 20:12 ` Marcus Folkesson
2018-02-10 20:12 ` Marcus Folkesson
2018-02-10 20:12 ` Marcus Folkesson
2018-02-10 20:12 ` Marcus Folkesson
2018-02-11 1:52 ` Guenter Roeck
2018-02-11 1:52 ` Guenter Roeck
2018-02-11 1:52 ` Guenter Roeck
2018-02-11 1:52 ` Guenter Roeck
2018-02-11 7:46 ` Sean Wang
2018-02-11 7:46 ` Sean Wang
2018-02-11 7:46 ` Sean Wang
2018-02-11 7:46 ` Sean Wang
2018-02-11 11:17 ` Guenter Roeck
2018-02-11 11:17 ` Guenter Roeck
2018-02-11 11:17 ` Guenter Roeck
2018-02-11 11:17 ` Guenter Roeck
2018-02-10 9:19 ` [PATCH v2 6/7] watchdog: meson: " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson [this message]
2018-02-10 9:19 ` [PATCH v2 7/7] watchdog: coh901327: make use of timeout-secs provided " Marcus Folkesson
2018-02-10 9:19 ` Marcus Folkesson
2018-02-11 17:33 ` [v2, " Guenter Roeck
2018-02-11 17:33 ` Guenter Roeck
2018-02-11 17:33 ` Guenter Roeck
2018-02-11 17:33 ` Guenter Roeck
2018-02-22 14:00 ` [PATCH v2 " Linus Walleij
2018-02-22 14:00 ` Linus Walleij
2018-02-22 14:00 ` Linus Walleij
2018-02-22 14:00 ` Linus Walleij
2018-02-10 14:29 ` [PATCH v2 1/7] watchdog: sama5d4: " Alexandre Belloni
2018-02-10 14:29 ` Alexandre Belloni
2018-02-10 14:29 ` Alexandre Belloni
2018-02-10 14:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180210091911.3644-7-marcus.folkesson@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=baohua@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.