From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: cantabile.desu@gmail.com
Cc: kubakici@wp.pl, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, linux-wireless@vger.kernel.org,
keescook@chromium.org, shuah@kernel.org, mfuzzey@parkeon.com,
zohar@linux.vnet.ibm.com, dhowells@redhat.com,
pali.rohar@gmail.com, tiwai@suse.de,
arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com,
markivx@codeaurora.org, stephen.boyd@linaro.org,
broonie@kernel.org, dmitry.torokhov@gmail.com,
dwmw2@infradead.org, torvalds@linux-foundation.org,
Abhay_Salunke@dell.com, bjorn.andersson@linaro.org,
jewalt@lgsinnovations.com, oneukum@suse.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [RFT 7/7] mt7601u: use request_firmware_cache() to address cache on reboot
Date: Tue, 27 Feb 2018 15:21:01 -0800 [thread overview]
Message-ID: <20180227232101.20786-8-mcgrof@kernel.org> (raw)
In-Reply-To: <20180227232101.20786-1-mcgrof@kernel.org>
request_firmware_cache() will ensure the firmware is available on resume
from suspend if on reboot the device retains the firmware.
This optimization is in place given otherwise on reboot we have to
reload the firmware, the opmization saves us about max 1s, minimum 10ms.
Reported-by: Cantabile <cantabile.desu@gmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
drivers/net/wireless/mediatek/mt7601u/mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/mcu.c b/drivers/net/wireless/mediatek/mt7601u/mcu.c
index 65a8004418ea..b90456a4b4d7 100644
--- a/drivers/net/wireless/mediatek/mt7601u/mcu.c
+++ b/drivers/net/wireless/mediatek/mt7601u/mcu.c
@@ -421,7 +421,7 @@ static int mt7601u_load_firmware(struct mt7601u_dev *dev)
MT_USB_DMA_CFG_TX_BULK_EN));
if (firmware_running(dev))
- return 0;
+ return request_firmware_cache(dev->dev, MT7601U_FIRMWARE);
ret = request_firmware(&fw, MT7601U_FIRMWARE, dev->dev);
if (ret)
--
2.16.2
next prev parent reply other threads:[~2018-02-27 23:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:20 [RFT 0/7] firmware: enable caching of firmware for reboot optimization Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 1/7] rename: _request_firmware_load() fw_load_sysfs_fallback() Luis R. Rodriguez
2018-02-27 23:28 ` Kees Cook
2018-02-28 1:21 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 2/7] firmware: fix checking for return values for fw_add_devm_name() Luis R. Rodriguez
2018-02-27 23:29 ` Kees Cook
2018-02-28 1:19 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 3/7] firmware: make fw_add_devm_name() return 0 if cache present Luis R. Rodriguez
2018-02-27 23:31 ` Kees Cook
2018-02-28 1:20 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 4/7] firmware: add helper to check to see if fw cache is setup Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 5/7] firmware: ensure the firmware cache is not used on incompatible calls Luis R. Rodriguez
2018-02-27 23:21 ` [RFT 6/7] firmware: add request_firmware_cache() to help with cache on reboot Luis R. Rodriguez
2018-02-27 23:21 ` Luis R. Rodriguez [this message]
2018-02-28 18:03 ` [RFT 0/7] firmware: enable caching of firmware for reboot optimization cantabile
2018-02-28 18:45 ` Luis R. Rodriguez
2018-02-28 21:18 ` cantabile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227232101.20786-8-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@linux-foundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cantabile.desu@gmail.com \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jewalt@lgsinnovations.com \
--cc=keescook@chromium.org \
--cc=kubakici@wp.pl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mfuzzey@parkeon.com \
--cc=nbroeking@me.com \
--cc=oneukum@suse.com \
--cc=pali.rohar@gmail.com \
--cc=shuah@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.