All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	cphealy@gmail.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM
Date: Wed, 28 Feb 2018 06:41:00 -0800	[thread overview]
Message-ID: <20180228144106.16363-17-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180228144106.16363-1-andrew.smirnov@gmail.com>

Being able to build this driver when COMPILE_TEST is selected is still
useful even when MESON_SM is not selected, since selecting this
driver as a module and doing "make modules" will result in successful
build and would detect trivial coding errors. For an example of type
of errors that could be prevented see [1] and [2]

[1] lkml.kernel.org/r/20171227225956.14442-12-andrew.smirnov@gmail.com
[2] https://marc.info/?l=linux-arm-kernel&m=151461599104358&w=2

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy@gmail.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ff505af064ba..42e84e1b2a26 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -147,7 +147,7 @@ config NVMEM_VF610_OCOTP
 
 config MESON_EFUSE
 	tristate "Amlogic Meson GX eFuse Support"
-	depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
+	depends on (ARCH_MESON && MESON_SM) || COMPILE_TEST
 	help
 	  This is a driver to retrieve specific values from the eFuse found on
 	  the Amlogic Meson GX SoCs.
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: andrew.smirnov@gmail.com (Andrey Smirnov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM
Date: Wed, 28 Feb 2018 06:41:00 -0800	[thread overview]
Message-ID: <20180228144106.16363-17-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180228144106.16363-1-andrew.smirnov@gmail.com>

Being able to build this driver when COMPILE_TEST is selected is still
useful even when MESON_SM is not selected, since selecting this
driver as a module and doing "make modules" will result in successful
build and would detect trivial coding errors. For an example of type
of errors that could be prevented see [1] and [2]

[1] lkml.kernel.org/r/20171227225956.14442-12-andrew.smirnov at gmail.com
[2] https://marc.info/?l=linux-arm-kernel&m=151461599104358&w=2

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy at gmail.com
Cc: linux-kernel at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ff505af064ba..42e84e1b2a26 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -147,7 +147,7 @@ config NVMEM_VF610_OCOTP
 
 config MESON_EFUSE
 	tristate "Amlogic Meson GX eFuse Support"
-	depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
+	depends on (ARCH_MESON && MESON_SM) || COMPILE_TEST
 	help
 	  This is a driver to retrieve specific values from the eFuse found on
 	  the Amlogic Meson GX SoCs.
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: andrew.smirnov@gmail.com (Andrey Smirnov)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM
Date: Wed, 28 Feb 2018 06:41:00 -0800	[thread overview]
Message-ID: <20180228144106.16363-17-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180228144106.16363-1-andrew.smirnov@gmail.com>

Being able to build this driver when COMPILE_TEST is selected is still
useful even when MESON_SM is not selected, since selecting this
driver as a module and doing "make modules" will result in successful
build and would detect trivial coding errors. For an example of type
of errors that could be prevented see [1] and [2]

[1] lkml.kernel.org/r/20171227225956.14442-12-andrew.smirnov at gmail.com
[2] https://marc.info/?l=linux-arm-kernel&m=151461599104358&w=2

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy at gmail.com
Cc: linux-kernel at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/nvmem/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ff505af064ba..42e84e1b2a26 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -147,7 +147,7 @@ config NVMEM_VF610_OCOTP
 
 config MESON_EFUSE
 	tristate "Amlogic Meson GX eFuse Support"
-	depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
+	depends on (ARCH_MESON && MESON_SM) || COMPILE_TEST
 	help
 	  This is a driver to retrieve specific values from the eFuse found on
 	  the Amlogic Meson GX SoCs.
-- 
2.14.3

  parent reply	other threads:[~2018-02-28 14:41 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 14:40 [PATCH v4 00/22] Verbatim device names and devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40 ` Andrey Smirnov
2018-02-28 14:40 ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 01/22] nvmem: Document struct nvmem_config Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 02/22] nvmem: core: Allow specifying device name verbatim Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 03/22] nvmem: Introduce devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 04/22] nvmem: vf610-ocotp: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 05/22] nvmem: imx-ocotp: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 06/22] nvmem: uniphier-efuse: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-03-04  0:46   ` kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-03-04  0:46   ` [PATCH] nvmem: uniphier-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-03-04  0:46     ` kbuild test robot
2018-02-28 14:40 ` [PATCH v4 07/22] nvmem: snvs_lgpr: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 08/22] nvmem: qfprom: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 09/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 10/22] nvmem: mtk-efuse: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 11/22] nvmem: meson-mx-efuse: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-03-04 11:13   ` kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-03-04 11:13   ` [PATCH] nvmem: meson-mx-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-03-04 11:13     ` kbuild test robot
2018-02-28 14:40 ` [PATCH v4 12/22] nvmem: meson-efuse: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 13/22] nvmem: lpc18xx_otp: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-03-04 13:04   ` kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-03-04 13:04   ` [PATCH] nvmem: lpc18xx_otp: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-03-04 13:04     ` kbuild test robot
2018-02-28 14:40 ` [PATCH v4 14/22] nvmem: imx-iim: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 15/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:40   ` Andrey Smirnov
2018-02-28 14:41 ` Andrey Smirnov [this message]
2018-02-28 14:41   ` [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-03-04  3:47   ` kbuild test robot
2018-03-04  3:47     ` kbuild test robot
2018-03-04  3:47     ` kbuild test robot
2018-03-04  3:47     ` kbuild test robot
2018-03-04 17:56   ` kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 17:56   ` [PATCH] nvmem: meson-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 17:56     ` kbuild test robot
2018-03-04 18:00     ` [kbuild-all] " Fabio Estevam
2018-03-04 18:00       ` Fabio Estevam
2018-03-04 18:00       ` Fabio Estevam
2018-02-28 14:41 ` [PATCH v4 17/22] nvmem: snvs_lpgpr: Convert commas to semicolons Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 18/22] nvmem: rockchip-efuse: Make use of of_device_get_match_data() Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 19/22] nvmem: vf610-ocotp: Do not use "&pdev->dev" explicitly Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 20/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 21/22] nvmem: imx-iim: " Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 22/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov
2018-02-28 14:41   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228144106.16363-17-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=carlo@caione.org \
    --cc=cphealy@gmail.com \
    --cc=heiko@sntech.de \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.