All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: kishon@ti.com, heiko@sntech.de
Cc: groeck@chromium.org, gwendal@chromium.org, kernel@collabora.com,
	vicencb@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional.
Date: Thu,  1 Mar 2018 16:25:11 +0100	[thread overview]
Message-ID: <20180301152515.20940-3-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180301152515.20940-1-enric.balletbo@collabora.com>

The extcon property is used to detect the cable-state but some boards
just connect the type-c phy to a regular USB-A connector without any
power-delivery and thus no controller reporting the cable-state.
So the extcon property is not really a required property, move it to be
optional instead.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---

Changes in v2:
- [2/6] Rewrite the justification as suggested by Heiko Stuebner.

 Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
index 6ea867e3176f..a66f23a01129 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
@@ -14,6 +14,8 @@ Required properties:
  - resets : a list of phandle + reset specifier pairs
  - reset-names : string reset name, must be:
 		 "uphy", "uphy-pipe", "uphy-tcphy"
+
+Optional properties:
  - extcon : extcon specifier for the Power Delivery
 
 Note, there are 2 type-c phys for RK3399, and they are almost identical, except
-- 
2.16.1

WARNING: multiple messages have this Message-ID (diff)
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: kishon@ti.com, heiko@sntech.de
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, gwendal@chromium.org,
	linux-kernel@vger.kernel.org, vicencb@gmail.com,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	groeck@chromium.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional.
Date: Thu,  1 Mar 2018 16:25:11 +0100	[thread overview]
Message-ID: <20180301152515.20940-3-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180301152515.20940-1-enric.balletbo@collabora.com>

The extcon property is used to detect the cable-state but some boards
just connect the type-c phy to a regular USB-A connector without any
power-delivery and thus no controller reporting the cable-state.
So the extcon property is not really a required property, move it to be
optional instead.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---

Changes in v2:
- [2/6] Rewrite the justification as suggested by Heiko Stuebner.

 Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
index 6ea867e3176f..a66f23a01129 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
@@ -14,6 +14,8 @@ Required properties:
  - resets : a list of phandle + reset specifier pairs
  - reset-names : string reset name, must be:
 		 "uphy", "uphy-pipe", "uphy-tcphy"
+
+Optional properties:
  - extcon : extcon specifier for the Power Delivery
 
 Note, there are 2 type-c phys for RK3399, and they are almost identical, except
-- 
2.16.1

WARNING: multiple messages have this Message-ID (diff)
From: enric.balletbo@collabora.com (Enric Balletbo i Serra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional.
Date: Thu,  1 Mar 2018 16:25:11 +0100	[thread overview]
Message-ID: <20180301152515.20940-3-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180301152515.20940-1-enric.balletbo@collabora.com>

The extcon property is used to detect the cable-state but some boards
just connect the type-c phy to a regular USB-A connector without any
power-delivery and thus no controller reporting the cable-state.
So the extcon property is not really a required property, move it to be
optional instead.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---

Changes in v2:
- [2/6] Rewrite the justification as suggested by Heiko Stuebner.

 Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
index 6ea867e3176f..a66f23a01129 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
@@ -14,6 +14,8 @@ Required properties:
  - resets : a list of phandle + reset specifier pairs
  - reset-names : string reset name, must be:
 		 "uphy", "uphy-pipe", "uphy-tcphy"
+
+Optional properties:
  - extcon : extcon specifier for the Power Delivery
 
 Note, there are 2 type-c phys for RK3399, and they are almost identical, except
-- 
2.16.1

  parent reply	other threads:[~2018-03-01 15:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 15:25 [PATCH v2 0/6] phy: rockchip-typec: fix boards that does not report cable-state Enric Balletbo i Serra
2018-03-01 15:25 ` Enric Balletbo i Serra
2018-03-01 15:25 ` Enric Balletbo i Serra
2018-03-01 15:25 ` [PATCH v2 1/6] phy: rockchip-typec: fall back to working in host-mode if extcon is missing Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-14  8:14   ` Heiko Stübner
2018-03-14  8:14     ` Heiko Stübner
2018-03-16  5:59     ` Kishon Vijay Abraham I
2018-03-16  5:59       ` Kishon Vijay Abraham I
2018-03-16  5:59       ` Kishon Vijay Abraham I
2018-03-01 15:25 ` Enric Balletbo i Serra [this message]
2018-03-01 15:25   ` [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-07 19:34   ` Rob Herring
2018-03-07 19:34     ` Rob Herring
2018-03-07 19:42     ` Alexandru Stan
2018-03-07 19:42       ` Alexandru Stan
2018-03-07 19:42       ` Alexandru Stan
2018-03-01 15:25 ` [PATCH v2 3/6] arm64: dts: rockchip: enable typec-phy for rk3399-sapphire Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-03 11:17   ` Vicente Bergas
2018-03-03 11:17     ` Vicente Bergas
2018-03-16 10:38   ` Heiko Stuebner
2018-03-16 10:38     ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 4/6] arm64: dts: rockchip: enable typec-phy for rk3399-firefly Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-16 10:38   ` Heiko Stuebner
2018-03-16 10:38     ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 5/6] arm64: dts: rockchip: enable typec-phy1 for rk3399-puma Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-02 19:49   ` klaus.goger
2018-03-02 19:49     ` klaus.goger at theobroma-systems.com
2018-03-16 10:39   ` Heiko Stuebner
2018-03-16 10:39     ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 6/6] arm64: dts: rockchip: enable typec-phy0 for rk3399-puma-haikou Enric Balletbo i Serra
2018-03-01 15:25   ` Enric Balletbo i Serra
2018-03-02 19:49   ` klaus.goger
2018-03-02 19:49     ` klaus.goger at theobroma-systems.com
2018-03-16 10:39   ` Heiko Stuebner
2018-03-16 10:39     ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301152515.20940-3-enric.balletbo@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.