All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PATCH 11/19] uninorth: enable internal PCI host bridge
Date: Tue,  6 Mar 2018 20:30:55 +0000	[thread overview]
Message-ID: <20180306203103.25563-12-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20180306203103.25563-1-mark.cave-ayland@ilande.co.uk>

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/pci-host/uninorth.c | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c
index 1f6752c294..ccde332fa9 100644
--- a/hw/pci-host/uninorth.c
+++ b/hw/pci-host/uninorth.c
@@ -213,6 +213,21 @@ static void pci_unin_agp_init(Object *obj)
     sysbus_init_mmio(sbd, &h->data_mem);
 }
 
+static void pci_unin_internal_realize(DeviceState *dev, Error **errp)
+{
+    UNINState *s = UNI_NORTH_INTERNAL_PCI_HOST_BRIDGE(dev);
+    PCIHostState *h = PCI_HOST_BRIDGE(dev);
+
+    h->bus = pci_register_root_bus(dev, NULL,
+                                   pci_unin_set_irq, pci_unin_map_irq,
+                                   s->pic_irqs,
+                                   &s->pci_mmio,
+                                   get_system_io(),
+                                   PCI_DEVFN(14, 0), 4, TYPE_PCI_BUS);
+
+    pci_create_simple(h->bus, PCI_DEVFN(14, 0), "uni-north-internal-pci");
+}
+
 static void pci_unin_internal_init(Object *obj)
 {
     SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
@@ -244,16 +259,12 @@ UNINState *pci_pmac_init(qemu_irq *pic,
     sysbus_mmio_map(s, 1, 0xf0c00000);
 
     /* Uninorth internal bus */
-#if 0
-    /* XXX: not needed for now */
-    pci_create_simple(h->bus, PCI_DEVFN(14, 0),
-                      "uni-north-internal-pci");
     dev = qdev_create(NULL, TYPE_UNI_NORTH_INTERNAL_PCI_HOST_BRIDGE);
+    qdev_prop_set_ptr(dev, "pic-irqs", pic);
     qdev_init_nofail(dev);
     s = SYS_BUS_DEVICE(dev);
     sysbus_mmio_map(s, 0, 0xf4800000);
     sysbus_mmio_map(s, 1, 0xf4c00000);
-#endif
 
     /* Uninorth main bus */
     dev = qdev_create(NULL, TYPE_UNI_NORTH_PCI_HOST_BRIDGE);
@@ -523,10 +534,17 @@ static const TypeInfo pci_unin_agp_info = {
     .class_init    = pci_unin_agp_class_init,
 };
 
+static Property pci_unin_internal_class_properties[] = {
+    DEFINE_PROP_PTR("pic-irqs", UNINState, pic_irqs),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
 static void pci_unin_internal_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
 
+    dc->realize = pci_unin_internal_realize;
+    dc->props = pci_unin_internal_class_properties;
     set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
 }
 
-- 
2.11.0

  parent reply	other threads:[~2018-03-06 20:36 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 20:30 [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board wiring improvements Mark Cave-Ayland
2018-03-06 20:30 ` [Qemu-devel] [PATCH 01/19] uninorth: trivial style fixups Mark Cave-Ayland
2018-03-06 22:49   ` Philippe Mathieu-Daudé
2018-03-07  2:25   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 02/19] uninorth: remove second set of uninorth token registers Mark Cave-Ayland
2018-03-07  4:11   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 03/19] uninorth: QOMify PCI and AGP host bridges Mark Cave-Ayland
2018-03-09  0:32   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 04/19] uninorth: remove stray PCIBus realize from mac_newworld.c Mark Cave-Ayland
2018-03-09  0:35   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 05/19] uninorth: move uninorth definitions into uninorth.h Mark Cave-Ayland
2018-03-06 22:50   ` Philippe Mathieu-Daudé
2018-03-14  5:43   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 06/19] uninorth: alter pci_pmac_init() and pci_pmac_u3_init() to return uninorth device Mark Cave-Ayland
2018-03-12 10:59   ` Philippe Mathieu-Daudé
2018-03-14  5:44   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 07/19] uninorth: move PCI mmio memory region initialisation into init function Mark Cave-Ayland
2018-03-06 23:44   ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2018-03-07  7:02     ` Mark Cave-Ayland
2018-03-07  7:23       ` Mark Cave-Ayland
2018-03-06 20:30 ` [Qemu-devel] [PATCH 08/19] uninorth: introduce temporary pic_irqs device property Mark Cave-Ayland
2018-03-14  6:20   ` David Gibson
2018-03-06 20:30 ` [Qemu-devel] [PATCH 09/19] uninorth: move PCI host bridge bus initialisation into device realize Mark Cave-Ayland
2018-03-12 11:04   ` Philippe Mathieu-Daudé
2018-03-06 20:30 ` [Qemu-devel] [PATCH 10/19] uninorth: fix PCI and AGP bus mixup Mark Cave-Ayland
2018-03-06 20:30 ` Mark Cave-Ayland [this message]
2018-03-06 20:30 ` [Qemu-devel] [PATCH 12/19] uninorth: remove obsolete pci_pmac_init() function Mark Cave-Ayland
2018-03-06 20:30 ` [Qemu-devel] [PATCH 13/19] uninorth: remove obsolete pci_pmac_u3_init() function Mark Cave-Ayland
2018-03-06 20:30 ` [Qemu-devel] [PATCH 14/19] uninorth: use object link to pass OpenPIC object to uninorth Mark Cave-Ayland
2018-03-06 20:30 ` [Qemu-devel] [PATCH 15/19] uninorth: move PCI IO (ISA) memory region into the uninorth device Mark Cave-Ayland
2018-03-12 11:01   ` Philippe Mathieu-Daudé
2018-03-06 20:31 ` [Qemu-devel] [PATCH 16/19] uninorth: rename UNINState to UNINHostState Mark Cave-Ayland
2018-03-06 22:52   ` Philippe Mathieu-Daudé
2018-03-06 20:31 ` [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device Mark Cave-Ayland
2018-03-21  3:29   ` David Gibson
2018-03-22  9:00     ` Philippe Mathieu-Daudé
2018-03-25 21:11       ` Mark Cave-Ayland
2018-04-06  5:33         ` Mark Cave-Ayland
2018-04-25  6:06           ` Mark Cave-Ayland
2018-04-25  6:34             ` David Gibson
2018-04-25  6:58               ` Mark Cave-Ayland
2018-04-25 14:35                 ` Philippe Mathieu-Daudé
2018-04-26  3:06                 ` David Gibson
2018-03-06 20:31 ` [Qemu-devel] [PATCH 18/19] mac_newworld: remove pics IRQ array and wire up macio to OpenPIC directly Mark Cave-Ayland
2018-03-21  3:40   ` David Gibson
2018-03-22  8:38   ` Philippe Mathieu-Daudé
2018-03-06 20:31 ` [Qemu-devel] [PATCH 19/19] mac_newworld: move wiring of macio IRQs to macio_newworld_realize() Mark Cave-Ayland
2018-03-21  3:42   ` David Gibson
2018-03-06 20:59 ` [Qemu-devel] [PATCH 00/19] uninorth fixes/mac_newworld board wiring improvements no-reply
2018-03-06 21:08   ` Mark Cave-Ayland
2018-03-14  5:40 ` David Gibson
2018-03-14  6:42 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306203103.25563-12-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.