All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [PATCH igt] igt/gem_mocs_settings: Wait for RC6 EI before polling
Date: Fri,  9 Mar 2018 10:42:40 +0000	[thread overview]
Message-ID: <20180309104240.6958-1-chris@chris-wilson.co.uk> (raw)

On bxt, we see that the rc6 subtest flip-flops as RC6 does not restart
within our desired interval. Improve the likelihood of the inspection
passing by idling the GPU and waiting for 2 Evaluation Intervals before
we start polling of RC6 residency.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_mocs_settings.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfd..85fd637a 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -336,12 +336,15 @@ static uint32_t rc6_residency(int dir)
 
 static void rc6_wait(int fd)
 {
-	int sysfs;
 	uint32_t residency;
+	int sysfs;
 
 	sysfs = igt_sysfs_open(fd, NULL);
 	igt_assert_lte(0, sysfs);
 
+	gem_quiescent_gpu(fd);
+	usleep(320e3); /* Wait for 2 EIs before polling; should now be active */
+
 	residency = rc6_residency(sysfs);
 	igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
 
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH igt] igt/gem_mocs_settings: Wait for RC6 EI before polling
Date: Fri,  9 Mar 2018 10:42:40 +0000	[thread overview]
Message-ID: <20180309104240.6958-1-chris@chris-wilson.co.uk> (raw)

On bxt, we see that the rc6 subtest flip-flops as RC6 does not restart
within our desired interval. Improve the likelihood of the inspection
passing by idling the GPU and waiting for 2 Evaluation Intervals before
we start polling of RC6 residency.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_mocs_settings.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/gem_mocs_settings.c b/tests/gem_mocs_settings.c
index 9705fbfd..85fd637a 100644
--- a/tests/gem_mocs_settings.c
+++ b/tests/gem_mocs_settings.c
@@ -336,12 +336,15 @@ static uint32_t rc6_residency(int dir)
 
 static void rc6_wait(int fd)
 {
-	int sysfs;
 	uint32_t residency;
+	int sysfs;
 
 	sysfs = igt_sysfs_open(fd, NULL);
 	igt_assert_lte(0, sysfs);
 
+	gem_quiescent_gpu(fd);
+	usleep(320e3); /* Wait for 2 EIs before polling; should now be active */
+
 	residency = rc6_residency(sysfs);
 	igt_require(igt_wait(rc6_residency(sysfs) != residency, 10000, 2));
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-03-09 10:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 10:42 Chris Wilson [this message]
2018-03-09 10:42 ` [igt-dev] [PATCH igt] igt/gem_mocs_settings: Wait for RC6 EI before polling Chris Wilson
2018-03-09 11:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-09 13:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-03-09 15:07 ` [igt-dev] [PATCH igt] " Michał Winiarski
2018-03-09 15:07   ` Michał Winiarski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309104240.6958-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.