All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: shawnguo@kernel.org, airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'
Date: Sun, 11 Mar 2018 23:32:03 +0100	[thread overview]
Message-ID: <20180311223203.3669-1-christophe.jaillet@wanadoo.fr> (raw)

'ret' is known to be 0 at this point. It must be updated by the value
returned by 'clk_prepare_enable()'.

Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/zte/zx_vou.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
index 7491813131f3..3351b258ed7a 100644
--- a/drivers/gpu/drm/zte/zx_vou.c
+++ b/drivers/gpu/drm/zte/zx_vou.c
@@ -838,7 +838,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	clk_prepare_enable(vou->ppu_clk);
+	ret = clk_prepare_enable(vou->ppu_clk);
 	if (ret) {
 		DRM_DEV_ERROR(dev, "failed to enable ppu_clk: %d\n", ret);
 		goto disable_axi_clk;
-- 
2.14.1


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: shawnguo@kernel.org, airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'
Date: Sun, 11 Mar 2018 22:32:03 +0000	[thread overview]
Message-ID: <20180311223203.3669-1-christophe.jaillet@wanadoo.fr> (raw)

'ret' is known to be 0 at this point. It must be updated by the value
returned by 'clk_prepare_enable()'.

Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/zte/zx_vou.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
index 7491813131f3..3351b258ed7a 100644
--- a/drivers/gpu/drm/zte/zx_vou.c
+++ b/drivers/gpu/drm/zte/zx_vou.c
@@ -838,7 +838,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	clk_prepare_enable(vou->ppu_clk);
+	ret = clk_prepare_enable(vou->ppu_clk);
 	if (ret) {
 		DRM_DEV_ERROR(dev, "failed to enable ppu_clk: %d\n", ret);
 		goto disable_axi_clk;
-- 
2.14.1


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus


             reply	other threads:[~2018-03-11 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 22:32 Christophe JAILLET [this message]
2018-03-11 22:32 ` [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()' Christophe JAILLET
2018-03-12  7:35 ` Shawn Guo
2018-03-12  7:35   ` Shawn Guo
2018-03-12  7:35   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180311223203.3669-1-christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.