All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin King <colin.king@canonical.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] ASoC: samsung: remove redundant pointer cpu_dai
Date: Tue, 13 Mar 2018 13:36:26 +0000	[thread overview]
Message-ID: <20180313133626.31286-1-colin.king@canonical.com> (raw)

From: Colin Ian King <colin.king@canonical.com>

The pointer cpu_dai is assigned a value but the pointer is never
read, hence it is redundant and can be removed.

Cleans up clang warning:
sound/soc/samsung/snow.c:45:2: warning: Value stored to 'cpu_dai' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/samsung/snow.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
index fc62110f500f..47b904e2b8c3 100644
--- a/sound/soc/samsung/snow.c
+++ b/sound/soc/samsung/snow.c
@@ -37,12 +37,10 @@ static int snow_late_probe(struct snd_soc_card *card)
 {
 	struct snd_soc_pcm_runtime *rtd;
 	struct snd_soc_dai *codec_dai;
-	struct snd_soc_dai *cpu_dai;
 	int ret;
 
 	rtd = snd_soc_get_pcm_runtime(card, card->dai_link[0].name);
 	codec_dai = rtd->codec_dai;
-	cpu_dai = rtd->cpu_dai;
 
 	/* Set the MCLK rate for the codec */
 	ret = snd_soc_dai_set_sysclk(codec_dai, 0,
-- 
2.15.1

             reply	other threads:[~2018-03-13 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 13:36 Colin King [this message]
2018-03-13 16:21 ` [PATCH][next] ASoC: samsung: remove redundant pointer cpu_dai Mark Brown
2018-03-13 16:21   ` Mark Brown
2018-03-13 16:21   ` Mark Brown
2018-03-13 16:22   ` Colin Ian King
2018-03-14 17:45 ` [alsa-devel] " kbuild test robot
2018-03-14 17:45   ` kbuild test robot
2018-03-14 17:45   ` [alsa-devel] " kbuild test robot
2018-03-14 18:08 ` kbuild test robot
2018-03-14 18:08   ` kbuild test robot
2018-03-14 18:08   ` [alsa-devel] " kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313133626.31286-1-colin.king@canonical.com \
    --to=colin.king@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.