All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v4 2/7] drm/i915/uc: Disable GuC submission during sanitize
Date: Fri, 23 Mar 2018 15:14:09 +0000	[thread overview]
Message-ID: <20180323151414.62580-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20180323151414.62580-1-michal.wajdeczko@intel.com>

We should not leave GuC submission enabled after sanitize,
as we are going to reset all GuC/HuC hardware.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_uc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 34f8a2c..2389828 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -331,6 +331,9 @@ void intel_uc_sanitize(struct drm_i915_private *i915)
 
 	GEM_BUG_ON(!HAS_GUC(i915));
 
+	if (USES_GUC_SUBMISSION(dev_priv))
+		intel_guc_submission_disable(guc);
+
 	guc_disable_communication(guc);
 
 	intel_huc_sanitize(huc);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-03-23 15:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 15:14 [PATCH v4 1/7] drm/i915: Correctly handle error path in i915_gem_init_hw Michal Wajdeczko
2018-03-23 15:14 ` Michal Wajdeczko [this message]
2018-03-26 10:36   ` [PATCH v4 2/7] drm/i915/uc: Disable GuC submission during sanitize Sagar Arun Kamble
2018-03-27 16:58     ` Michal Wajdeczko
2018-03-23 15:14 ` [PATCH v4 3/7] drm/i915/uc: Fully sanitize uC in uc_fini_hw Michal Wajdeczko
2018-03-26 11:23   ` Sagar Arun Kamble
2018-03-27 17:07     ` Michal Wajdeczko
2018-03-23 15:14 ` [PATCH v4 4/7] drm/i915/uc: Use correct error code for GuC initialization failure Michal Wajdeczko
2018-03-23 15:14 ` [PATCH v4 5/7] drm/i915/uc: Use helper functions to detect fw load status Michal Wajdeczko
2018-03-23 15:14 ` [PATCH v4 6/7] drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c Michal Wajdeczko
2018-03-23 15:14 ` [PATCH v4 7/7] HAX: Enable GuC for CI Michal Wajdeczko
2018-03-23 17:18 ` ✓ Fi.CI.BAT: success for series starting with [v4,1/7] drm/i915: Correctly handle error path in i915_gem_init_hw Patchwork
2018-03-23 20:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-26 10:16 ` [PATCH v4 1/7] " Sagar Arun Kamble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323151414.62580-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.