From: Bartosz Golaszewski <brgl@bgdev.pl> To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, David Lechner <david@lechnology.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: [PATCH v3 4/8] remoteproc/davinci: add the missing retval check for clk_enable() Date: Tue, 27 Mar 2018 11:20:27 +0200 [thread overview] Message-ID: <20180327092031.11251-5-brgl@bgdev.pl> (raw) In-Reply-To: <20180327092031.11251-1-brgl@bgdev.pl> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> The davinci platform is being switched to using the common clock framework, where clk_enable() can fail. Add the return value check. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Acked-by: Suman Anna <s-anna@ti.com> --- drivers/remoteproc/da8xx_remoteproc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index bf3b9034c319..2b24291337b7 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc) struct device *dev = rproc->dev.parent; struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv; struct clk *dsp_clk = drproc->dsp_clk; + int ret; /* hw requires the start (boot) address be on 1KB boundary */ if (rproc->bootaddr & 0x3ff) { @@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc) writel(rproc->bootaddr, drproc->bootreg); - clk_enable(dsp_clk); + ret = clk_enable(dsp_clk); + if (ret) { + dev_err(dev, "clk_enable() failed: %d\n", ret); + return ret; + } + davinci_clk_reset_deassert(dsp_clk); return 0; -- 2.16.1
WARNING: multiple messages have this Message-ID (diff)
From: brgl@bgdev.pl (Bartosz Golaszewski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/8] remoteproc/davinci: add the missing retval check for clk_enable() Date: Tue, 27 Mar 2018 11:20:27 +0200 [thread overview] Message-ID: <20180327092031.11251-5-brgl@bgdev.pl> (raw) In-Reply-To: <20180327092031.11251-1-brgl@bgdev.pl> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> The davinci platform is being switched to using the common clock framework, where clk_enable() can fail. Add the return value check. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Acked-by: Suman Anna <s-anna@ti.com> --- drivers/remoteproc/da8xx_remoteproc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index bf3b9034c319..2b24291337b7 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc) struct device *dev = rproc->dev.parent; struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv; struct clk *dsp_clk = drproc->dsp_clk; + int ret; /* hw requires the start (boot) address be on 1KB boundary */ if (rproc->bootaddr & 0x3ff) { @@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc) writel(rproc->bootaddr, drproc->bootreg); - clk_enable(dsp_clk); + ret = clk_enable(dsp_clk); + if (ret) { + dev_err(dev, "clk_enable() failed: %d\n", ret); + return ret; + } + davinci_clk_reset_deassert(dsp_clk); return 0; -- 2.16.1
next prev parent reply other threads:[~2018-03-27 9:20 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-27 9:20 [PATCH v3 0/8] ARM: davinci: complete the conversion to using the reset framework Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 1/8] ARM: davinci: dts: make psc0 a reset provider Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 2/8] ARM: davinci: dts: add a reset control to the dsp node Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 3/8] clk: davinci: add a reset lookup table for psc0 Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski [this message] 2018-03-27 9:20 ` [PATCH v3 4/8] remoteproc/davinci: add the missing retval check for clk_enable() Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 5/8] remoteproc/davinci: prepare and unprepare the clock where needed Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 6/8] remoteproc/davinci: use octal permissions for module_param() Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-28 22:20 ` Suman Anna 2018-03-28 22:20 ` Suman Anna 2018-03-28 22:20 ` Suman Anna 2018-03-27 9:20 ` [PATCH v3 7/8] remoteproc/davinci: use the reset framework Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-28 22:30 ` Suman Anna 2018-03-28 22:30 ` Suman Anna 2018-03-28 22:30 ` Suman Anna 2018-03-29 7:16 ` Bartosz Golaszewski 2018-03-29 7:16 ` Bartosz Golaszewski 2018-03-27 9:20 ` [PATCH v3 8/8] clk: davinci: kill davinci_clk_reset_assert/deassert() Bartosz Golaszewski 2018-03-27 9:20 ` Bartosz Golaszewski 2018-03-27 9:25 ` [PATCH v3 0/8] ARM: davinci: complete the conversion to using the reset framework Philipp Zabel 2018-03-27 9:25 ` Philipp Zabel 2018-03-27 9:25 ` Philipp Zabel 2018-03-27 16:48 ` David Lechner 2018-03-27 16:48 ` David Lechner 2018-03-30 11:07 ` Bartosz Golaszewski 2018-03-30 11:07 ` Bartosz Golaszewski 2018-03-28 22:41 ` Suman Anna 2018-03-28 22:41 ` Suman Anna 2018-03-28 22:41 ` Suman Anna 2018-03-28 22:41 ` Suman Anna
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180327092031.11251-5-brgl@bgdev.pl \ --to=brgl@bgdev.pl \ --cc=bgolaszewski@baylibre.com \ --cc=bjorn.andersson@linaro.org \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nsekhar@ti.com \ --cc=ohad@wizery.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.