All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: Anatolij Gustschin <agust@denx.de>,
	Matthew Gerlach <matthew.gerlach@linux.intel.com>,
	Joel Holdsworth <joel@airwebreathe.org.uk>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Joshua Clayton <stillcompiling@gmail.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Alan Tull <atull@kernel.org>,
	linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: [RESEND PATCH v3 1/4] fpga: region: don't use drvdata in common fpga code
Date: Tue, 27 Mar 2018 14:59:54 -0500	[thread overview]
Message-ID: <20180327195957.3878-2-atull@kernel.org> (raw)
In-Reply-To: <20180327195957.3878-1-atull@kernel.org>

Part of patchset that changes the following fpga_*_register
functions to not set drvdata:
* fpga_region_register.
* fpga_mgr_register
* fpga_bridge_register

The rationale is that setting drvdata is fine for DT based devices
that will have one manager, bridge, or region per platform device.
However PCIe based devices may have multiple FPGA mgr/bridge/regions
under one PCIe device.  Without these changes, the PCIe solution has
to create an extra device for each child mgr/bridge/region to hold
drvdata.

Signed-off-by: Alan Tull <atull@kernel.org>
Reported-by: Jiuyue Ma <majiuyue@huawei.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
---
v2: No change to this patch in v2 of patchset
v3: Add Moritz' ack
---
 drivers/fpga/fpga-region.c    | 1 -
 drivers/fpga/of-fpga-region.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index edab2a2e03ef..ebe1f872810d 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -178,7 +178,6 @@ int fpga_region_register(struct device *dev, struct fpga_region *region)
 	region->dev.parent = dev;
 	region->dev.of_node = dev->of_node;
 	region->dev.id = id;
-	dev_set_drvdata(dev, region);
 
 	ret = dev_set_name(&region->dev, "region%d", id);
 	if (ret)
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index 119ff75522f1..35e7e8c4a0cb 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -438,6 +438,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
 		goto eprobe_mgr_put;
 
 	of_platform_populate(np, fpga_region_of_match, NULL, &region->dev);
+	dev_set_drvdata(dev, region);
 
 	dev_info(dev, "FPGA Region probed\n");
 
-- 
2.14.2

  reply	other threads:[~2018-03-27 20:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 19:59 [RESEND PATCH v3 0/4] fpga: don't use drvdata in common code Alan Tull
2018-03-27 19:59 ` Alan Tull [this message]
2018-03-27 19:59 ` [RESEND PATCH v3 2/4] fpga: manager: don't use drvdata in common fpga code Alan Tull
2018-03-27 20:11   ` Moritz Fischer
2018-03-27 21:19     ` Alan Tull
2018-03-27 19:59 ` [RESEND PATCH v3 3/4] fpga: bridge: " Alan Tull
2018-03-27 20:10   ` Moritz Fischer
2018-03-27 19:59 ` [RESEND PATCH v3 4/4] fpga: region: change fpga_region_register to have one param Alan Tull
2018-03-27 20:09   ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327195957.3878-2-atull@kernel.org \
    --to=atull@kernel.org \
    --cc=agust@denx.de \
    --cc=dinguyen@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=joel@airwebreathe.org.uk \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=mdf@kernel.org \
    --cc=stillcompiling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.