All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com,
	kvm@vger.kernel.org, mst@redhat.com,
	syzkaller-bugs@googlegroups.com,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH RESEND net] vhost: fix vhost_vq_access_ok() log check
Date: Mon, 9 Apr 2018 22:40:02 +0300	[thread overview]
Message-ID: <20180409174731-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180409131021.5132-1-stefanha@redhat.com>

From: Stefan Hajnoczi <stefanha@redhat.com>

Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log
when IOTLB is enabled") introduced a regression.  The logic was
originally:

  if (vq->iotlb)
      return 1;
  return A && B;

After the patch the short-circuit logic for A was inverted:

  if (A || vq->iotlb)
      return A;
  return B;

The correct logic is:

  if (!A || vq->iotlb)
      return A;
  return B;

Reported-by: syzbot+65a84dde0214b0387ccd@syzkaller.appspotmail.com
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>

---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 5320039671b7..f6af4210679a 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1246,7 +1246,7 @@ int vhost_vq_access_ok(struct vhost_virtqueue *vq)
 {
 	int ret = vq_log_access_ok(vq, vq->log_base);
 
-	if (ret || vq->iotlb)
+	if (!ret || vq->iotlb)
 		return ret;
 
 	return vq_access_ok(vq, vq->num, vq->desc, vq->avail, vq->used);
-- 
2.14.3

  parent reply	other threads:[~2018-04-09 19:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 13:10 [PATCH] vhost: fix vhost_vq_access_ok() log check Stefan Hajnoczi
2018-04-09 13:58 ` Michael S. Tsirkin
2018-04-09 13:58   ` Michael S. Tsirkin
2018-04-09 16:52 ` Linus Torvalds
2018-04-09 16:52 ` Linus Torvalds
2018-04-09 19:54   ` Michael S. Tsirkin
2018-04-09 19:54   ` Michael S. Tsirkin
2018-04-09 19:40 ` Michael S. Tsirkin [this message]
2018-04-10  1:05   ` [PATCH RESEND net] " Stefan Hajnoczi
2018-04-10  1:05   ` Stefan Hajnoczi
2018-04-09 19:40 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409174731-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@redhat.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.