From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: broonie@kernel.org Cc: linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>, b.zolnierkie@samsung.com, krzk@kernel.org, linux-spi@vger.kernel.org, kgene@kernel.org, andi@etezian.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: [PATCH v2 3/8] spi: spi-s3c64xx: Remove unused s3c64xx_spi_hwinit() function argument Date: Tue, 17 Apr 2018 16:29:49 +0200 [thread overview] Message-ID: <20180417142954.5507-3-s.nawrocki@samsung.com> (raw) In-Reply-To: <20180417142954.5507-1-s.nawrocki@samsung.com> The channel argument is not used and anyway the value could be retrieved from the passed driver data structure. Reviewed-by: Andi Shyti <andi@etezian.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index f0e28adbbc32..4c27426bcb40 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -891,7 +891,7 @@ static irqreturn_t s3c64xx_spi_irq(int irq, void *data) return IRQ_HANDLED; } -static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd, int channel) +static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) { struct s3c64xx_spi_info *sci = sdd->cntrlr_info; void __iomem *regs = sdd->regs; @@ -1145,7 +1145,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) pm_runtime_get_sync(&pdev->dev); /* Setup Deufult Mode */ - s3c64xx_spi_hwinit(sdd, sdd->port_id); + s3c64xx_spi_hwinit(sdd); spin_lock_init(&sdd->lock); init_completion(&sdd->xfer_completion); @@ -1260,7 +1260,7 @@ static int s3c64xx_spi_resume(struct device *dev) if (ret < 0) return ret; - s3c64xx_spi_hwinit(sdd, sdd->port_id); + s3c64xx_spi_hwinit(sdd); return spi_master_resume(master); } -- 2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/8] spi: spi-s3c64xx: Remove unused s3c64xx_spi_hwinit() function argument Date: Tue, 17 Apr 2018 16:29:49 +0200 [thread overview] Message-ID: <20180417142954.5507-3-s.nawrocki@samsung.com> (raw) In-Reply-To: <20180417142954.5507-1-s.nawrocki@samsung.com> The channel argument is not used and anyway the value could be retrieved from the passed driver data structure. Reviewed-by: Andi Shyti <andi@etezian.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index f0e28adbbc32..4c27426bcb40 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -891,7 +891,7 @@ static irqreturn_t s3c64xx_spi_irq(int irq, void *data) return IRQ_HANDLED; } -static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd, int channel) +static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) { struct s3c64xx_spi_info *sci = sdd->cntrlr_info; void __iomem *regs = sdd->regs; @@ -1145,7 +1145,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) pm_runtime_get_sync(&pdev->dev); /* Setup Deufult Mode */ - s3c64xx_spi_hwinit(sdd, sdd->port_id); + s3c64xx_spi_hwinit(sdd); spin_lock_init(&sdd->lock); init_completion(&sdd->xfer_completion); @@ -1260,7 +1260,7 @@ static int s3c64xx_spi_resume(struct device *dev) if (ret < 0) return ret; - s3c64xx_spi_hwinit(sdd, sdd->port_id); + s3c64xx_spi_hwinit(sdd); return spi_master_resume(master); } -- 2.14.2
next prev parent reply other threads:[~2018-04-17 14:29 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20180417143022epcas2p1185d48998a1659ce6580180ea6725607@epcas2p1.samsung.com> 2018-04-17 14:29 ` [PATCH v2 1/8] spi: spi-s3c64xx: Do not ignore timeout errors in polling I/O mode Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki [not found] ` <CGME20180417143028epcas1p459b6358287256a1c060ea95847ce9fbd@epcas1p4.samsung.com> 2018-04-17 14:29 ` [PATCH v2 2/8] spi: spi-s3c64xx: Remove unused driver data structure tgl_spi field Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki [not found] ` <CGME20180417143035epcas2p2959c3987da80bf28cacc603168204f4c@epcas2p2.samsung.com> 2018-04-17 14:29 ` Sylwester Nawrocki [this message] 2018-04-17 14:29 ` [PATCH v2 3/8] spi: spi-s3c64xx: Remove unused s3c64xx_spi_hwinit() function argument Sylwester Nawrocki [not found] ` <CGME20180417143039epcas2p39e2c730d107c94e5f9bf104d3a938f90@epcas2p3.samsung.com> 2018-04-17 14:29 ` [PATCH v2 4/8] spi: spi-s3c64xx: Drop unused enable_datapath() " Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki 2018-04-17 18:09 ` andi 2018-04-17 18:09 ` andi at etezian.org 2018-04-18 11:40 ` Applied "spi: spi-s3c64xx: Drop unused enable_datapath() function argument" to the spi tree Mark Brown 2018-04-18 11:40 ` Mark Brown [not found] ` <CGME20180417143045epcas2p2ac92ce458223a849647265d59b12bc70@epcas2p2.samsung.com> 2018-04-17 14:29 ` [PATCH v2 5/8] spi: spi-s3c64xx: Add missing s3c64xx_ prefix to function names Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki 2018-04-17 18:11 ` andi 2018-04-17 18:11 ` andi at etezian.org 2018-04-18 11:40 ` Applied "spi: spi-s3c64xx: Add missing s3c64xx_ prefix to function names" to the spi tree Mark Brown 2018-04-18 11:40 ` Mark Brown [not found] ` <CGME20180417143049epcas2p1a9244272897740ac03d7a21d5dfb5d14@epcas2p1.samsung.com> 2018-04-17 14:29 ` [PATCH v2 6/8] spi: spi-s3c64xx: Fix indentation in the register offset definitions Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki 2018-04-18 10:47 ` Mark Brown 2018-04-18 10:47 ` Mark Brown 2018-04-18 12:17 ` Sylwester Nawrocki 2018-04-18 12:17 ` Sylwester Nawrocki 2018-04-18 13:49 ` Mark Brown 2018-04-18 13:49 ` Mark Brown [not found] ` <CGME20180417143053epcas1p2a1bf34ea178d1f20fee3c6ade18bf17d@epcas1p2.samsung.com> 2018-04-17 14:29 ` [PATCH v2 7/8] spi: spi-s3c64xx: Use local variable for FIFO length Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki 2018-04-17 18:14 ` andi 2018-04-17 18:14 ` andi at etezian.org 2018-04-18 11:40 ` Applied "spi: spi-s3c64xx: Use local variable for FIFO length" to the spi tree Mark Brown 2018-04-18 11:40 ` Mark Brown [not found] ` <CGME20180417143100epcas2p228d05e4de4ce06621635a523241d9824@epcas2p2.samsung.com> 2018-04-17 14:29 ` [PATCH v2 8/8] spi: spi-s3c64xx: Allow higher transfer lengths in polling IO mode Sylwester Nawrocki 2018-04-17 14:29 ` Sylwester Nawrocki 2018-04-17 18:27 ` andi 2018-04-17 18:27 ` andi at etezian.org 2018-04-18 11:40 ` Applied "spi: spi-s3c64xx: Allow higher transfer lengths in polling IO mode" to the spi tree Mark Brown 2018-04-18 11:40 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180417142954.5507-3-s.nawrocki@samsung.com \ --to=s.nawrocki@samsung.com \ --cc=andi@etezian.org \ --cc=b.zolnierkie@samsung.com \ --cc=broonie@kernel.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.