From: Miquel Raynal <miquel.raynal@bootlin.com> To: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>, devicetree@vger.kernel.org, Antoine Tenart <antoine.tenart@bootlin.com>, Catalin Marinas <catalin.marinas@arm.com>, Gregory Clement <gregory.clement@bootlin.com>, Haim Boot <hayim@marvell.com>, Will Deacon <will.deacon@arm.com>, Maxime Chevallier <maxime.chevallier@bootlin.com>, Nadav Haklai <nadavh@marvell.com>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Hanna Hawa <hannah@marvell.com>, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Subject: [PATCH 04/17] irqchip/irq-mvebu-icu: fix wrong user data retrieval Date: Sat, 21 Apr 2018 15:55:24 +0200 [thread overview] Message-ID: <20180421135537.24716-5-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180421135537.24716-1-miquel.raynal@bootlin.com> The irq_domain structure has an host_data pointer that just stores user data. It is meant to not be touched by the IRQ core. However, when it comes to MSI, the MSI layer adds its own private data there with a structure that also has a host_data pointer. Because this IRQ domain is an MSI domain, to access user data we should do a d->host_data->host_data, also wrapped as 'platform_msi_get_host_data()'. This bug was lying there silently because the 'icu' structure retrieved this way was just called by dev_err(), only producing a '(NULL device *):' output on the console. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/irqchip/irq-mvebu-icu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index e18c48d3a92e..6a77b9ea8e41 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -92,7 +92,7 @@ static int mvebu_icu_irq_domain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, unsigned long *hwirq, unsigned int *type) { - struct mvebu_icu *icu = d->host_data; + struct mvebu_icu *icu = platform_msi_get_host_data(d); unsigned int icu_group; /* Check the count of the parameters in dt */ -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@bootlin.com (Miquel Raynal) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/17] irqchip/irq-mvebu-icu: fix wrong user data retrieval Date: Sat, 21 Apr 2018 15:55:24 +0200 [thread overview] Message-ID: <20180421135537.24716-5-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180421135537.24716-1-miquel.raynal@bootlin.com> The irq_domain structure has an host_data pointer that just stores user data. It is meant to not be touched by the IRQ core. However, when it comes to MSI, the MSI layer adds its own private data there with a structure that also has a host_data pointer. Because this IRQ domain is an MSI domain, to access user data we should do a d->host_data->host_data, also wrapped as 'platform_msi_get_host_data()'. This bug was lying there silently because the 'icu' structure retrieved this way was just called by dev_err(), only producing a '(NULL device *):' output on the console. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/irqchip/irq-mvebu-icu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index e18c48d3a92e..6a77b9ea8e41 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -92,7 +92,7 @@ static int mvebu_icu_irq_domain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, unsigned long *hwirq, unsigned int *type) { - struct mvebu_icu *icu = d->host_data; + struct mvebu_icu *icu = platform_msi_get_host_data(d); unsigned int icu_group; /* Check the count of the parameters in dt */ -- 2.14.1
next prev parent reply other threads:[~2018-04-21 13:55 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-21 13:55 [PATCH 00/17] Add System Error Interrupt support to Armada SoCs Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 01/17] dt-bindings/interrupt-controller: fix Marvell ICU length in the example Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-27 20:16 ` Rob Herring 2018-04-27 20:16 ` Rob Herring 2018-04-30 13:44 ` Thomas Petazzoni 2018-04-30 13:44 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 02/17] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-30 12:38 ` Gregory CLEMENT 2018-04-30 12:38 ` Gregory CLEMENT 2018-04-30 13:44 ` Thomas Petazzoni 2018-04-30 13:44 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 03/17] arm64: dts: marvell: add syscon compatible to CP110 ICU node Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-30 13:45 ` Thomas Petazzoni 2018-04-30 13:45 ` Thomas Petazzoni 2018-04-21 13:55 ` Miquel Raynal [this message] 2018-04-21 13:55 ` [PATCH 04/17] irqchip/irq-mvebu-icu: fix wrong user data retrieval Miquel Raynal 2018-04-30 13:49 ` Thomas Petazzoni 2018-04-30 13:49 ` Thomas Petazzoni 2018-05-03 14:57 ` Miquel Raynal 2018-05-03 14:57 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 05/17] irqchip/irq-mvebu-icu: clarify the reset operation of configured interrupts Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-30 13:51 ` Thomas Petazzoni 2018-04-30 13:51 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 06/17] irqchip/irq-mvebu-icu: switch to regmap Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-30 12:42 ` Gregory CLEMENT 2018-04-30 12:42 ` Gregory CLEMENT 2018-04-30 13:53 ` Thomas Petazzoni 2018-04-30 13:53 ` Thomas Petazzoni 2018-05-03 15:05 ` Miquel Raynal 2018-05-03 15:05 ` Miquel Raynal 2018-04-30 13:58 ` Thomas Petazzoni 2018-04-30 13:58 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 07/17] irqchip/irq-mvebu-icu: make irq_domain local Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-05-02 8:02 ` Thomas Petazzoni 2018-05-02 8:02 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 08/17] irqchip/irq-mvebu-icu: disociate ICU and NSR Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-05-02 8:03 ` Thomas Petazzoni 2018-05-02 8:03 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 09/17] irqchip/irq-mvebu-icu: support ICU subnodes Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-05-02 8:13 ` Thomas Petazzoni 2018-05-02 8:13 ` Thomas Petazzoni 2018-05-04 8:32 ` Miquel Raynal 2018-05-04 8:32 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 10/17] irqchip/irq-mvebu-sei: add new driver for Marvell SEI Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-05-02 9:17 ` Thomas Petazzoni 2018-05-02 9:17 ` Thomas Petazzoni 2018-05-02 15:56 ` Thomas Petazzoni 2018-05-02 15:56 ` Thomas Petazzoni 2018-05-18 13:22 ` Miquel Raynal 2018-05-18 13:22 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 11/17] arm64: marvell: enable SEI driver Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-30 13:01 ` Gregory CLEMENT 2018-04-30 13:01 ` Gregory CLEMENT 2018-04-21 13:55 ` [PATCH 12/17] irqchip/irq-mvebu-icu: add support for System Error Interrupts (SEI) Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 13/17] dt-bindings/interrupt-controller: update Marvell ICU bindings Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-27 20:47 ` Rob Herring 2018-04-27 20:47 ` Rob Herring 2018-04-28 10:42 ` Miquel Raynal 2018-04-28 10:42 ` Miquel Raynal 2018-04-28 10:50 ` Thomas Petazzoni 2018-04-28 10:50 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 14/17] dt-bindings/interrupt-controller: add description for Marvell SEI node Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-27 20:50 ` Rob Herring 2018-04-27 20:50 ` Rob Herring 2018-04-28 10:48 ` Miquel Raynal 2018-04-28 10:48 ` Miquel Raynal 2018-04-30 14:09 ` Rob Herring 2018-04-30 14:09 ` Rob Herring 2018-05-18 14:48 ` Miquel Raynal 2018-05-18 14:48 ` Miquel Raynal 2018-04-30 14:24 ` Thomas Petazzoni 2018-04-30 14:24 ` Thomas Petazzoni 2018-04-21 13:55 ` [PATCH 15/17] arm64: dts: marvell: add AP806 SEI subnode Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 16/17] arm64: dts: marvell: use new bindings for CP110 interrupts Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal 2018-04-21 13:55 ` [PATCH 17/17] arm64: dts: marvell: add CP110 ICU SEI subnode Miquel Raynal 2018-04-21 13:55 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180421135537.24716-5-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=andrew@lunn.ch \ --cc=antoine.tenart@bootlin.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=hannah@marvell.com \ --cc=hayim@marvell.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=nadavh@marvell.com \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tglx@linutronix.de \ --cc=thomas.petazzoni@bootlin.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.