All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Regnery <tobias.regnery@gmail.com>
To: architt@codeaurora.org, a.hajda@samsung.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: m.purski@samsung.com, Tobias Regnery <tobias.regnery@gmail.com>
Subject: [PATCH] drm/bridge/sii8620: fix link error
Date: Mon, 23 Apr 2018 10:47:00 +0200	[thread overview]
Message-ID: <20180423084700.27888-1-tobias.regnery@gmail.com> (raw)

With CONFIG_EXTCON=m and CONFIG_DRM_SIL_SII8620=y we see the following link
error:

drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_remove':
sil-sii8620.c:(.text+0xd5): undefined reference to `extcon_unregister_notifier'
drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_probe':
sil-sii8620.c:(.text+0x2a4b): undefined reference to `extcon_find_edev_by_node'
sil-sii8620.c:(.text+0x2af4): undefined reference to `extcon_register_notifier'
drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_work':
sil-sii8620.c:(.text+0x2b94): undefined reference to `extcon_get_state'

Fix this by selecting EXTCON.

Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 3aa65bdecb0e..ab99e36ee034 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -74,6 +74,7 @@ config DRM_SIL_SII8620
 	tristate "Silicon Image SII8620 HDMI/MHL bridge"
 	depends on OF && RC_CORE
 	select DRM_KMS_HELPER
+	select EXTCON
 	help
 	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
 
-- 
2.17.0

             reply	other threads:[~2018-04-23  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180423085639epcas3p13d9c120cba4c41bf3f0f18be25f83590@epcas3p1.samsung.com>
2018-04-23  8:47 ` Tobias Regnery [this message]
2018-04-23  9:22   ` [PATCH] drm/bridge/sii8620: fix link error Andrzej Hajda
2018-04-23  9:22     ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180423084700.27888-1-tobias.regnery@gmail.com \
    --to=tobias.regnery@gmail.com \
    --cc=a.hajda@samsung.com \
    --cc=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.purski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.