All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aring@mojatatu.com>
To: stefan@osg.samsung.com
Cc: linux-wpan@vger.kernel.org, kernel@mojatatu.com,
	Alexander Aring <aring@mojatatu.com>
Subject: [RFC PATCH wpan-tools 1/2] wpan-ping: fix ifname setting
Date: Fri, 27 Apr 2018 17:24:17 -0400	[thread overview]
Message-ID: <20180427212418.29729-2-aring@mojatatu.com> (raw)
In-Reply-To: <20180427212418.29729-1-aring@mojatatu.com>

This patch fix ifname setting, we should use the ifname stored inside
this string and not give the programming declaration where to find the
string. Founded by code inspection.

Signed-off-by: Alexander Aring <aring@mojatatu.com>
---
 wpan-ping/wpan-ping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wpan-ping/wpan-ping.c b/wpan-ping/wpan-ping.c
index f825b22..791346c 100644
--- a/wpan-ping/wpan-ping.c
+++ b/wpan-ping/wpan-ping.c
@@ -194,7 +194,7 @@ static int get_interface_info(struct config *conf) {
 	nl_socket_modify_cb(conf->nl_sock, NL_CB_VALID, NL_CB_CUSTOM, nl_msg_cb, conf);
 	msg = nlmsg_alloc();
 	genlmsg_put(msg, NL_AUTO_PORT, NL_AUTO_SEQ, conf->nl802154_id, 0, NLM_F_DUMP, NL802154_CMD_GET_INTERFACE, 0);
-	nla_put_string(msg, NL802154_ATTR_IFNAME, "conf->interface");
+	nla_put_string(msg, NL802154_ATTR_IFNAME, conf->interface);
 	nl_send_sync(conf->nl_sock, msg);
 
 	nl802154_cleanup(conf);
-- 
2.11.0


  reply	other threads:[~2018-04-27 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 21:24 [RFC PATCH wpan-tools 0/2] wpan-hwsim: introduce new user space tool Alexander Aring
2018-04-27 21:24 ` Alexander Aring [this message]
2018-05-07 12:02   ` [RFC PATCH wpan-tools 1/2] wpan-ping: fix ifname setting Stefan Schmidt
2018-04-27 21:24 ` [RFC PATCH wpan-tools 2/2] wpan-hwsim: initial commit Alexander Aring
2018-05-07 12:44   ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427212418.29729-2-aring@mojatatu.com \
    --to=aring@mojatatu.com \
    --cc=kernel@mojatatu.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=stefan@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.