All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: "Peter Rosin" <peda@axentia.se>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Joonyoung Shim" <jy0922.shim@samsung.com>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"David Airlie" <airlied@linux.ie>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH 3/3] drm/exynos: hdmi: avoid duplicating drm_bridge_attach
Date: Wed,  2 May 2018 09:40:25 +0200	[thread overview]
Message-ID: <20180502074025.12421-4-peda@axentia.se> (raw)
In-Reply-To: <20180502074025.12421-1-peda@axentia.se>

drm_bridge_attach takes care of these assignments, so there is no need
to open-code them a second time.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index abd84cbcf1c2..09c4bc0b1859 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -954,8 +954,6 @@ static int hdmi_create_connector(struct drm_encoder *encoder)
 	drm_mode_connector_attach_encoder(connector, encoder);
 
 	if (hdata->bridge) {
-		encoder->bridge = hdata->bridge;
-		hdata->bridge->encoder = encoder;
 		ret = drm_bridge_attach(encoder, hdata->bridge, NULL);
 		if (ret)
 			DRM_ERROR("Failed to attach bridge\n");
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: peda@axentia.se (Peter Rosin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] drm/exynos: hdmi: avoid duplicating drm_bridge_attach
Date: Wed,  2 May 2018 09:40:25 +0200	[thread overview]
Message-ID: <20180502074025.12421-4-peda@axentia.se> (raw)
In-Reply-To: <20180502074025.12421-1-peda@axentia.se>

drm_bridge_attach takes care of these assignments, so there is no need
to open-code them a second time.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index abd84cbcf1c2..09c4bc0b1859 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -954,8 +954,6 @@ static int hdmi_create_connector(struct drm_encoder *encoder)
 	drm_mode_connector_attach_encoder(connector, encoder);
 
 	if (hdata->bridge) {
-		encoder->bridge = hdata->bridge;
-		hdata->bridge->encoder = encoder;
 		ret = drm_bridge_attach(encoder, hdata->bridge, NULL);
 		if (ret)
 			DRM_ERROR("Failed to attach bridge\n");
-- 
2.11.0

  parent reply	other threads:[~2018-05-02  7:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  7:40 [PATCH 0/3] drm: fix some bridge api misunderstandings Peter Rosin
2018-05-02  7:40 ` Peter Rosin
2018-05-02  7:40 ` [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added Peter Rosin
2018-05-02  7:40   ` Peter Rosin
2018-05-03  9:06   ` Daniel Vetter
2018-05-03  9:06     ` Daniel Vetter
2018-05-03  9:06     ` Daniel Vetter
2018-05-03 21:12     ` Peter Rosin
2018-05-03 21:12       ` Peter Rosin
2018-05-07 13:39       ` Daniel Vetter
2018-05-07 13:39         ` Daniel Vetter
2018-05-07 13:39         ` Daniel Vetter
2018-05-07 13:59         ` Peter Rosin
2018-05-07 13:59           ` Peter Rosin
2018-05-07 14:24           ` Peter Rosin
2018-05-07 14:24             ` Peter Rosin
2018-05-08  7:51             ` Daniel Vetter
2018-05-08  7:51               ` Daniel Vetter
2018-05-08  7:41           ` Daniel Vetter
2018-05-08  7:41             ` Daniel Vetter
2018-05-08  7:41             ` Daniel Vetter
2018-05-02  7:40 ` [PATCH 2/3] drm/rockchip: lvds: avoid duplicating drm_bridge_attach Peter Rosin
2018-05-02  7:40   ` Peter Rosin
2018-05-20 11:48   ` Heiko Stuebner
2018-05-20 11:48     ` Heiko Stuebner
2018-05-20 11:48     ` Heiko Stuebner
2018-05-02  7:40 ` Peter Rosin [this message]
2018-05-02  7:40   ` [PATCH 3/3] drm/exynos: hdmi: " Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502074025.12421-4-peda@axentia.se \
    --to=peda@axentia.se \
    --cc=airlied@linux.ie \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.