All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <tony@atomide.com>
Cc: <bcousson@baylibre.com>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<j-keerthy@ti.com>
Subject: [PATCH 1/4] ARM: dts: am437x-gp-evm: Fixup (again) tps65218 irq type
Date: Tue, 8 May 2018 16:20:50 +0300	[thread overview]
Message-ID: <20180508132053.5471-2-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20180508132053.5471-1-peter.ujfalusi@ti.com>

While the correct IRQ level fixed the WARN_ON(), but prevented the probe
of tps65218 as GIC_SPI does not support LEVEL_LOW (?)

Use LEVEL_HIGH as it looks to be the accurate one since the INTn of TPS is
connected to NMIn of the SoC.

Fixes: 5692b911c980 ("ARM: dts: am437x-gp-evm: Correct tps65218 irq type")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index d0192e07adc6..60414b1ca404 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -543,7 +543,7 @@
 	tps65218: tps65218@24 {
 		reg = <0x24>;
 		compatible = "ti,tps65218";
-		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; /* NMIn */
+		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* NMIn */
 		interrupt-controller;
 		#interrupt-cells = <2>;
 
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tony@atomide.com
Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	j-keerthy@ti.com
Subject: [PATCH 1/4] ARM: dts: am437x-gp-evm: Fixup (again) tps65218 irq type
Date: Tue, 8 May 2018 16:20:50 +0300	[thread overview]
Message-ID: <20180508132053.5471-2-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20180508132053.5471-1-peter.ujfalusi@ti.com>

While the correct IRQ level fixed the WARN_ON(), but prevented the probe
of tps65218 as GIC_SPI does not support LEVEL_LOW (?)

Use LEVEL_HIGH as it looks to be the accurate one since the INTn of TPS is
connected to NMIn of the SoC.

Fixes: 5692b911c980 ("ARM: dts: am437x-gp-evm: Correct tps65218 irq type")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index d0192e07adc6..60414b1ca404 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -543,7 +543,7 @@
 	tps65218: tps65218@24 {
 		reg = <0x24>;
 		compatible = "ti,tps65218";
-		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; /* NMIn */
+		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* NMIn */
 		interrupt-controller;
 		#interrupt-cells = <2>;
 
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2018-05-08 13:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:20 [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type Peter Ujfalusi
2018-05-08 13:20 ` Peter Ujfalusi
2018-05-08 13:20 ` Peter Ujfalusi [this message]
2018-05-08 13:20   ` [PATCH 1/4] ARM: dts: am437x-gp-evm: Fixup " Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 4/4] Revert "ARM: dts: am437x-sk-evm: Correct tps65218 irq type" Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 14:16 ` [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type Tony Lindgren
2018-05-09  4:00   ` Keerthy
2018-05-09  4:00     ` Keerthy
2018-05-15 18:15     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508132053.5471-2-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.