From: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk> To: tiwai@suse.com Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ruslan.bilovol@gmail.com, Jorge Sanjuan <jorge.sanjuan@codethink.co.uk> Subject: [PATCH v4 4/4] ALSA: usb-audio: UAC3: Parse Input Terminal number of channels. Date: Fri, 11 May 2018 16:25:37 +0100 [thread overview] Message-ID: <20180511152537.32267-5-jorge.sanjuan@codethink.co.uk> (raw) In-Reply-To: <20180511152537.32267-1-jorge.sanjuan@codethink.co.uk> Obtain the number of channels for the Input Terminal from the Logical Cluster Descriptor. This achieves a useful minimal parsing of this unit so it can be used in other units in the topology. Signed-off-by: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk> --- sound/usb/mixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 431f3c319839..19b25fbc7437 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -903,9 +903,9 @@ static int check_input_term(struct mixer_build *state, int id, * recursion calls */ term->id = id; term->type = le16_to_cpu(d->wTerminalType); + term->channels = get_cluster_channels_v3(state, d->wClusterDescrID); - /* REVISIT: UAC3 IT doesn't have channels/cfg */ - term->channels = 0; + /* REVISIT: UAC3 IT doesn't have channels cfg */ term->chconfig = 0; term->name = le16_to_cpu(d->wTerminalDescrStr); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk> To: tiwai@suse.com Cc: gregkh@linuxfoundation.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>, ruslan.bilovol@gmail.com Subject: [PATCH v4 4/4] ALSA: usb-audio: UAC3: Parse Input Terminal number of channels. Date: Fri, 11 May 2018 16:25:37 +0100 [thread overview] Message-ID: <20180511152537.32267-5-jorge.sanjuan@codethink.co.uk> (raw) In-Reply-To: <20180511152537.32267-1-jorge.sanjuan@codethink.co.uk> Obtain the number of channels for the Input Terminal from the Logical Cluster Descriptor. This achieves a useful minimal parsing of this unit so it can be used in other units in the topology. Signed-off-by: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk> --- sound/usb/mixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 431f3c319839..19b25fbc7437 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -903,9 +903,9 @@ static int check_input_term(struct mixer_build *state, int id, * recursion calls */ term->id = id; term->type = le16_to_cpu(d->wTerminalType); + term->channels = get_cluster_channels_v3(state, d->wClusterDescrID); - /* REVISIT: UAC3 IT doesn't have channels/cfg */ - term->channels = 0; + /* REVISIT: UAC3 IT doesn't have channels cfg */ term->chconfig = 0; term->name = le16_to_cpu(d->wTerminalDescrStr); -- 2.11.0
next prev parent reply other threads:[~2018-05-11 15:25 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 17:03 [PATCH 0/4] ALSA: usb: UAC3 new features Jorge Sanjuan 2018-04-20 17:03 ` [PATCH 1/4] ALSA: usb-audio: UAC3. Add support for mixer unit Jorge Sanjuan 2018-04-20 17:03 ` Jorge Sanjuan 2018-04-23 11:03 ` Takashi Iwai 2018-04-23 11:03 ` Takashi Iwai 2018-04-20 17:03 ` [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3 Jorge Sanjuan 2018-04-20 17:03 ` Jorge Sanjuan 2018-04-23 12:11 ` Takashi Iwai 2018-04-23 12:11 ` Takashi Iwai 2018-04-24 8:03 ` [alsa-devel] " Ruslan Bilovol 2018-04-24 8:03 ` Ruslan Bilovol 2018-04-20 17:03 ` [PATCH 3/4] ALSA: usb-audio: Use Class Specific EP for UAC3 devices Jorge Sanjuan 2018-04-20 17:03 ` Jorge Sanjuan 2018-04-22 20:30 ` [alsa-devel] " kbuild test robot 2018-04-22 20:30 ` kbuild test robot 2018-04-20 17:03 ` [PATCH 4/4] ALSA: usb-audio: UAC3 Add support for connector insertion Jorge Sanjuan 2018-04-22 20:55 ` kbuild test robot 2018-04-22 20:55 ` kbuild test robot 2018-04-23 12:19 ` Takashi Iwai 2018-04-23 12:19 ` Takashi Iwai 2018-04-23 16:06 ` Jorge 2018-04-24 17:24 ` [PATCH v2 0/4] ALSA: usb: UAC3 new features Jorge Sanjuan 2018-04-24 17:24 ` Jorge Sanjuan 2018-04-24 17:24 ` [PATCH v2 1/4] ALSA: usb-audio: UAC3. Add support for mixer unit Jorge Sanjuan 2018-04-25 22:35 ` [alsa-devel] " Ruslan Bilovol 2018-04-26 16:56 ` Jorge 2018-04-26 16:56 ` Jorge 2018-04-27 17:06 ` [PATCH v3 " Jorge Sanjuan 2018-04-27 17:06 ` Jorge Sanjuan 2018-05-04 0:57 ` Ruslan Bilovol 2018-05-08 9:43 ` Jorge 2018-05-09 22:11 ` Ruslan Bilovol 2018-04-24 17:24 ` [PATCH v2 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3 Jorge Sanjuan 2018-04-24 17:55 ` Takashi Iwai 2018-04-24 17:55 ` Takashi Iwai 2018-04-24 17:24 ` [PATCH v2 3/4] ALSA: usb-audio: Use Class Specific EP for UAC3 devices Jorge Sanjuan 2018-04-24 17:24 ` Jorge Sanjuan 2018-04-25 22:53 ` [alsa-devel] " Ruslan Bilovol 2018-04-24 17:24 ` [PATCH v2 4/4] ALSA: usb-audio: UAC3 Add support for connector insertion Jorge Sanjuan 2018-04-24 17:24 ` Jorge Sanjuan 2018-04-24 18:02 ` [PATCH v2 0/4] ALSA: usb: UAC3 new features Takashi Iwai 2018-04-24 18:02 ` Takashi Iwai 2018-04-26 9:26 ` [alsa-devel] " Ruslan Bilovol 2018-04-26 9:26 ` Ruslan Bilovol 2018-04-26 17:13 ` [alsa-devel] " Jorge 2018-05-11 15:25 ` [PATCH v4 " Jorge Sanjuan 2018-05-11 15:25 ` Jorge Sanjuan 2018-05-11 15:25 ` [PATCH v4 1/4] ALSA: usb-audio: UAC3. Add support for mixer unit Jorge Sanjuan 2018-05-11 15:25 ` Jorge Sanjuan 2018-05-14 20:54 ` Ruslan Bilovol 2018-05-11 15:25 ` [PATCH v4 2/4] ALSA: usb-audio: Use Class Specific EP for UAC3 devices Jorge Sanjuan 2018-05-14 21:00 ` Ruslan Bilovol 2018-05-11 15:25 ` [PATCH v4 3/4] ALSA: usb-audio: UAC3 Add support for connector insertion Jorge Sanjuan 2018-05-11 15:25 ` Jorge Sanjuan [this message] 2018-05-11 15:25 ` [PATCH v4 4/4] ALSA: usb-audio: UAC3: Parse Input Terminal number of channels Jorge Sanjuan 2018-05-14 8:54 ` Jorge 2018-05-14 9:36 ` Ruslan Bilovol 2018-05-14 11:03 ` [RESEND PATCH " Jorge Sanjuan 2018-05-14 11:03 ` Jorge Sanjuan 2018-05-14 21:05 ` Ruslan Bilovol 2018-05-14 21:05 ` Ruslan Bilovol 2018-05-15 5:38 ` [PATCH v4 0/4] ALSA: usb: UAC3 new features Takashi Iwai 2018-05-15 5:38 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180511152537.32267-5-jorge.sanjuan@codethink.co.uk \ --to=jorge.sanjuan@codethink.co.uk \ --cc=alsa-devel@alsa-project.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ruslan.bilovol@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.