All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 01/10] drm/i915: Mark up nested spinlocks
Date: Mon, 14 May 2018 10:37:01 +0100	[thread overview]
Message-ID: <20180514093710.7730-2-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180514093710.7730-1-chris@chris-wilson.co.uk>

When we process the outstanding requests upon banning a context, we need
to acquire both the engine and the client's timeline, nesting the locks.
This requires explicit markup as the two timelines are now of the same
class, since commit a89d1f921c15 ("drm/i915: Split i915_gem_timeline into
individual timelines").

Testcase: igt/gem_eio/banned
Fixes: a89d1f921c15 ("drm/i915: Split i915_gem_timeline into individual timelines")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 89bf5d67cb74..0a2070112b66 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3119,7 +3119,7 @@ static void engine_skip_context(struct i915_request *request)
 	GEM_BUG_ON(timeline == &engine->timeline);
 
 	spin_lock_irqsave(&engine->timeline.lock, flags);
-	spin_lock(&timeline->lock);
+	spin_lock_nested(&timeline->lock, SINGLE_DEPTH_NESTING);
 
 	list_for_each_entry_continue(request, &engine->timeline.requests, link)
 		if (request->ctx == hung_ctx)
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-14  9:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  9:37 Direct execlists submission Chris Wilson
2018-05-14  9:37 ` Chris Wilson [this message]
2018-05-14 10:06   ` [PATCH 01/10] drm/i915: Mark up nested spinlocks Tvrtko Ursulin
2018-05-14  9:37 ` [PATCH 02/10] drm/i915: Remove tasklet flush before disable Chris Wilson
2018-05-14  9:37 ` [PATCH 03/10] drm/i915: Wrap tasklet_struct for abuse Chris Wilson
2018-05-14  9:37 ` [PATCH 04/10] drm/i915: Only sync tasklets once for recursive reset preparation Chris Wilson
2018-05-14  9:37 ` [PATCH 05/10] drm/i915/execlists: Direct submit onto idle engines Chris Wilson
2018-05-14  9:37 ` [PATCH 06/10] drm/i915/execlists: Direct submission from irq handler Chris Wilson
2018-05-14  9:37 ` [PATCH 07/10] drm/i915: Rearrange gen8_cs_irq_handler Chris Wilson
2018-05-14  9:37 ` [PATCH 08/10] drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler Chris Wilson
2018-05-14 10:27   ` Tvrtko Ursulin
2018-05-14 11:45     ` Chris Wilson
2018-05-14  9:37 ` [PATCH 09/10] drm/i915: Speed up idle detection by kicking the tasklets Chris Wilson
2018-05-14  9:37 ` [PATCH 10/10] drm/i915: Detect if we missed kicking the execlists tasklet Chris Wilson
2018-05-14  9:42 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915: Mark up nested spinlocks Patchwork
2018-05-14  9:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-14  9:59 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-14 10:11 ` Direct execlists submission Tvrtko Ursulin
2018-05-14 10:25   ` Chris Wilson
2018-05-14 14:54     ` Chris Wilson
2018-05-14 12:45 ` ✓ Fi.CI.IGT: success for series starting with [01/10] drm/i915: Mark up nested spinlocks Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514093710.7730-2-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.