All of lore.kernel.org
 help / color / mirror / Atom feed
From: Su Yue <suy.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <suy.fnst@cn.fujitsu.com>
Subject: [PATCH 2/3] btrfs-progs: lowmem: check symlinks with append/immutable flags
Date: Mon, 14 May 2018 18:29:21 +0800	[thread overview]
Message-ID: <20180514102922.8840-3-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20180514102922.8840-1-suy.fnst@cn.fujitsu.com>

Symlinks should never have append/immutable flags.
While checking inodes, if found a symlink with append/immutable
flags, report and record the fatal error.

This is for lowmem mode.

Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
 check/mode-lowmem.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c
index 9890180d1d3c..61c4e7f23d47 100644
--- a/check/mode-lowmem.c
+++ b/check/mode-lowmem.c
@@ -2274,6 +2274,7 @@ static int check_inode_item(struct btrfs_root *root, struct btrfs_path *path)
 	struct btrfs_key last_key;
 	u64 inode_id;
 	u32 mode;
+	u64 flags;
 	u64 nlink;
 	u64 nbytes;
 	u64 isize;
@@ -2307,10 +2308,19 @@ static int check_inode_item(struct btrfs_root *root, struct btrfs_path *path)
 	isize = btrfs_inode_size(node, ii);
 	nbytes = btrfs_inode_nbytes(node, ii);
 	mode = btrfs_inode_mode(node, ii);
+	flags = btrfs_inode_flags(node, ii);
 	dir = imode_to_type(mode) == BTRFS_FT_DIR;
 	nlink = btrfs_inode_nlink(node, ii);
 	nodatasum = btrfs_inode_flags(node, ii) & BTRFS_INODE_NODATASUM;
 
+	if (mode & BTRFS_FT_SYMLINK &&
+	    (flags & (BTRFS_INODE_IMMUTABLE | BTRFS_INODE_APPEND))) {
+		err = FATAL_ERROR;
+		error(
+"symlinks shall never be with immutable/append, root %llu inode item [%llu] flags %llu may be corrupted",
+		      root->objectid, inode_id, flags);
+	}
+
 	while (1) {
 		btrfs_item_key_to_cpu(path->nodes[0], &last_key, path->slots[0]);
 		ret = btrfs_next_item(root, path);
-- 
2.17.0




  parent reply	other threads:[~2018-05-14 10:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 10:29 [PATCH 0/3] btrfs-progs: check: verify symlinks with append/immutable flags Su Yue
2018-05-14 10:29 ` [PATCH 1/3] btrfs-progs: check: check " Su Yue
2018-05-14 11:18   ` Nikolay Borisov
2018-05-14 12:12     ` Su Yue
2018-05-14 11:22   ` Qu Wenruo
2018-05-14 11:52     ` Su Yue
2018-05-14 10:29 ` Su Yue [this message]
2018-05-14 11:17   ` [PATCH 2/3] btrfs-progs: lowmem: " Nikolay Borisov
2018-05-14 12:04     ` Su Yue
2018-05-14 11:27   ` Qu Wenruo
2018-05-14 10:29 ` [PATCH 3/3] btrfs-progs: fsck-tests: add test case to check symlinks with odd flags Su Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514102922.8840-3-suy.fnst@cn.fujitsu.com \
    --to=suy.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.