All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: jack@suse.cz, guaneryu@gmail.com, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] generic: fix cleanup function for test 490
Date: Sun, 20 May 2018 14:45:17 -0400	[thread overview]
Message-ID: <20180520184517.8826-1-tytso@mit.edu> (raw)

generic/490 fails because cleanup tries to delete . and .. since $tmp
is left unset, and so "rm -f $tmp.*" does nothing useful.  Instead
delete temp files created by seek_sanity_test.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/generic/490 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/490 b/tests/generic/490
index b5042c2e..c0335ca0 100755
--- a/tests/generic/490
+++ b/tests/generic/490
@@ -49,7 +49,7 @@ _require_test_program "seek_sanity_test"
 _cleanup()
 {
 	cd /
-	rm -f $tmp.*
+	rm -f $base_test_file*
 }
 
 $here/src/seek_sanity_test -s 19 -e 20 $base_test_file > $seqres.full 2>&1 ||
-- 
2.16.1.72.g5be1f00a9a


             reply	other threads:[~2018-05-20 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 18:45 Theodore Ts'o [this message]
2018-05-21  2:29 ` [PATCH] generic: fix cleanup function for test 490 Eryu Guan
2018-05-21  2:41 ` Dave Chinner
2018-05-21  2:54   ` Eryu Guan
2018-05-25  0:29     ` Dave Chinner
2018-05-25  0:59       ` Widespread test setup template problems (was Re: [PATCH] generic: fix cleanup function for test 490) Dave Chinner
2018-05-25  1:23         ` Dave Chinner
2018-05-25  4:17           ` Eric Biggers
2018-05-25  6:25             ` Dave Chinner
2018-05-25  8:06               ` Amir Goldstein
2018-05-25  8:45                 ` Dave Chinner
2018-05-25 22:33                   ` Eric Biggers
2018-05-25 23:25                     ` Dave Chinner
2018-05-27 12:38           ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520184517.8826-1-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=jack@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.