From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Michal Hocko" <mhocko@suse.com>, "Jan Kara" <jack@suse.cz>,
"kbuild test robot" <lkp@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Linux MM" <linux-mm@kvack.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Thomas Meyer" <thomas@m3y3r.de>
Subject: Re: [PATCH v10] mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS
Date: Wed, 23 May 2018 20:50:17 +0200 [thread overview]
Message-ID: <20180523205017.0f2bc83e@thinkpad> (raw)
In-Reply-To: <20180522062806.GD7816@lst.de>
On Tue, 22 May 2018 08:28:06 +0200
Christoph Hellwig <hch@lst.de> wrote:
> On Mon, May 21, 2018 at 11:04:10AM +0200, Jan Kara wrote:
> > We definitely do have customers using "execute in place" on s390x from
> > dcssblk. I've got about two bug reports for it when customers were updating
> > from old kernels using original XIP to kernels using DAX. So we need to
> > keep that working.
>
> That is all good an fine, but I think time has come where s390 needs
> to migrate to provide the pmem API so that we can get rid of these
> special cases. Especially given that the old XIP/legacy DAX has all
> kinds of known bugs at this point in time.
I haven't yet looked at this patch series, but I can feel that this
FS_DAX_LIMITED workaround is beginning to cause some headaches, apart
from being quite ugly of course.
Just to make sure I still understand the basic problem, which I thought
was missing struct pages for the dcssblk memory, what exactly do you
mean with "provide the pmem API", is there more to do?
I do have a prototype patch lying around that adds struct pages, but
didn't yet have time to fully test/complete it. Of course we initially
introduced XIP as a mechanism to reduce memory consumption, and that
is probably the use case for the remaining customer(s). Adding struct
pages would somehow reduce that benefit, but as long as we can still
"execute in place", I guess it will be OK.
Regards,
Gerald
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jan Kara" <jack@suse.cz>,
"Dan Williams" <dan.j.williams@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Michal Hocko" <mhocko@suse.com>,
"kbuild test robot" <lkp@intel.com>,
"Thomas Meyer" <thomas@m3y3r.de>,
"Dave Jiang" <dave.jiang@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>
Subject: Re: [PATCH v10] mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS
Date: Wed, 23 May 2018 20:50:17 +0200 [thread overview]
Message-ID: <20180523205017.0f2bc83e@thinkpad> (raw)
In-Reply-To: <20180522062806.GD7816@lst.de>
On Tue, 22 May 2018 08:28:06 +0200
Christoph Hellwig <hch@lst.de> wrote:
> On Mon, May 21, 2018 at 11:04:10AM +0200, Jan Kara wrote:
> > We definitely do have customers using "execute in place" on s390x from
> > dcssblk. I've got about two bug reports for it when customers were updating
> > from old kernels using original XIP to kernels using DAX. So we need to
> > keep that working.
>
> That is all good an fine, but I think time has come where s390 needs
> to migrate to provide the pmem API so that we can get rid of these
> special cases. Especially given that the old XIP/legacy DAX has all
> kinds of known bugs at this point in time.
I haven't yet looked at this patch series, but I can feel that this
FS_DAX_LIMITED workaround is beginning to cause some headaches, apart
from being quite ugly of course.
Just to make sure I still understand the basic problem, which I thought
was missing struct pages for the dcssblk memory, what exactly do you
mean with "provide the pmem API", is there more to do?
I do have a prototype patch lying around that adds struct pages, but
didn't yet have time to fully test/complete it. Of course we initially
introduced XIP as a mechanism to reduce memory consumption, and that
is probably the use case for the remaining customer(s). Adding struct
pages would somehow reduce that benefit, but as long as we can still
"execute in place", I guess it will be OK.
Regards,
Gerald
next prev parent reply other threads:[~2018-05-23 18:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 20:06 [PATCH v10] mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS Dan Williams
2018-05-17 20:06 ` Dan Williams
2018-05-17 20:06 ` Dan Williams
2018-05-18 9:00 ` Jan Kara
2018-05-18 9:00 ` Jan Kara
2018-05-18 9:46 ` Christoph Hellwig
2018-05-18 9:46 ` Christoph Hellwig
2018-05-18 16:00 ` Dan Williams
2018-05-18 16:00 ` Dan Williams
2018-05-21 9:04 ` Jan Kara
2018-05-22 6:28 ` Christoph Hellwig
2018-05-22 6:28 ` Christoph Hellwig
2018-05-23 18:50 ` Gerald Schaefer [this message]
2018-05-23 18:50 ` Gerald Schaefer
2018-05-29 20:26 ` Dan Williams
2018-05-29 20:26 ` Dan Williams
2018-06-01 15:01 ` Gerald Schaefer
2018-06-01 15:01 ` Gerald Schaefer
2018-06-02 0:03 ` Dan Williams
2018-06-02 0:03 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523205017.0f2bc83e@thinkpad \
--to=gerald.schaefer@de.ibm.com \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=mhocko@suse.com \
--cc=schwidefsky@de.ibm.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.