All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v7 1/7] drm/i915: Program RPCS for Broadwell
Date: Thu, 24 May 2018 15:54:38 +0100	[thread overview]
Message-ID: <20180524145444.19302-2-lionel.g.landwerlin@intel.com> (raw)
In-Reply-To: <20180524145444.19302-1-lionel.g.landwerlin@intel.com>

From: Chris Wilson <chris@chris-wilson.co.uk>

Currently we only configure the power gating for Skylake and above, but
the configuration should equally apply to Broadwell and Braswell. Even
though, there is not as much variation as for later generations, we want
to expose control over the configuration to userspace and may want to
opt out of the "always-enabled" setting.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_lrc.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 857ab04452f0..c2500c209c63 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2486,13 +2486,6 @@ make_rpcs(struct drm_i915_private *dev_priv)
 {
 	u32 rpcs = 0;
 
-	/*
-	 * No explicit RPCS request is needed to ensure full
-	 * slice/subslice/EU enablement prior to Gen9.
-	*/
-	if (INTEL_GEN(dev_priv) < 9)
-		return 0;
-
 	/*
 	 * Starting in Gen9, render power gating can leave
 	 * slice/subslice/EU in a partially enabled state. We
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-24 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 14:54 [PATCH v7 0/7] drm/i915: per context slice/subslice powergating Lionel Landwerlin
2018-05-24 14:54 ` Lionel Landwerlin [this message]
2018-05-24 14:54 ` [PATCH v7 2/7] drm/i915: Record the sseu configuration per-context & engine Lionel Landwerlin
2018-05-24 14:54 ` [PATCH v7 3/7] drm/i915/perf: simplify configure all context function Lionel Landwerlin
2018-05-24 14:54 ` [PATCH v7 4/7] drm/i915/perf: reuse intel_lrc ctx regs macro Lionel Landwerlin
2018-05-24 14:54 ` [PATCH v7 5/7] drm/i915/perf: lock powergating configuration to default when active Lionel Landwerlin
2018-05-24 14:54 ` [PATCH v7 6/7] drm/i915: Expose RPCS (SSEU) configuration to userspace Lionel Landwerlin
2018-05-24 14:54 ` [PATCH v7 7/7] drm/i915: add a sysfs entry to let users set sseu configs Lionel Landwerlin
2018-05-24 15:35   ` Tvrtko Ursulin
2018-05-24 16:10     ` Lionel Landwerlin
2018-05-24 15:41 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: per context slice/subslice powergating (rev6) Patchwork
2018-05-24 15:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-24 15:56 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-24 20:07 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524145444.19302-2-lionel.g.landwerlin@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.