From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Wolfram Sang <wsa+renesas@sang-engineering.com>, Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH/RFT 4/6] i2c: davinci: set SDA as output for recovery Date: Fri, 13 Jul 2018 23:09:16 +0200 [thread overview] Message-ID: <20180713210920.3648-5-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20180713210920.3648-1-wsa+renesas@sang-engineering.com> This allows for sending STOP when generating pulses which is much more robust because it will bring clients into a default state. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-davinci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index d945a2654c2f..478acf0870aa 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -874,7 +874,8 @@ static int davinci_i2c_probe(struct platform_device *pdev) r = PTR_ERR(rinfo->scl_gpiod); goto err_unuse_clocks; } - rinfo->sda_gpiod = devm_gpiod_get(&pdev->dev, "sda", GPIOD_IN); + rinfo->sda_gpiod = devm_gpiod_get(&pdev->dev, "sda", + GPIOD_OUT_HIGH_OPEN_DRAIN); if (IS_ERR(rinfo->sda_gpiod)) { r = PTR_ERR(rinfo->sda_gpiod); goto err_unuse_clocks; -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: wsa+renesas@sang-engineering.com (Wolfram Sang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH/RFT 4/6] i2c: davinci: set SDA as output for recovery Date: Fri, 13 Jul 2018 23:09:16 +0200 [thread overview] Message-ID: <20180713210920.3648-5-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20180713210920.3648-1-wsa+renesas@sang-engineering.com> This allows for sending STOP when generating pulses which is much more robust because it will bring clients into a default state. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-davinci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index d945a2654c2f..478acf0870aa 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -874,7 +874,8 @@ static int davinci_i2c_probe(struct platform_device *pdev) r = PTR_ERR(rinfo->scl_gpiod); goto err_unuse_clocks; } - rinfo->sda_gpiod = devm_gpiod_get(&pdev->dev, "sda", GPIOD_IN); + rinfo->sda_gpiod = devm_gpiod_get(&pdev->dev, "sda", + GPIOD_OUT_HIGH_OPEN_DRAIN); if (IS_ERR(rinfo->sda_gpiod)) { r = PTR_ERR(rinfo->sda_gpiod); goto err_unuse_clocks; -- 2.11.0
next prev parent reply other threads:[~2018-07-13 21:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-13 21:09 [PATCH/RFT 0/6] i2c: recovery: fix GPIO usage for recovery Wolfram Sang 2018-07-13 21:09 ` Wolfram Sang 2018-07-13 21:09 ` Wolfram Sang 2018-07-13 21:09 ` [PATCH/RFT 1/6] i2c: designware: use open drain for recovery GPIO Wolfram Sang 2018-07-16 0:47 ` Phil Reid 2018-07-17 9:09 ` Wolfram Sang 2018-07-17 9:27 ` Phil Reid 2018-07-24 7:26 ` Wolfram Sang 2018-07-25 3:26 ` Phil Reid 2018-07-13 21:09 ` [PATCH/RFT 2/6] i2c: imx: " Wolfram Sang 2018-07-23 12:47 ` Lucas Stach 2018-07-24 7:28 ` Wolfram Sang 2018-07-24 13:01 ` Wolfram Sang 2018-07-13 21:09 ` [PATCH/RFT 3/6] i2c: designware: set SDA as output for recovery Wolfram Sang 2018-07-13 21:09 ` Wolfram Sang [this message] 2018-07-13 21:09 ` [PATCH/RFT 4/6] i2c: davinci: " Wolfram Sang 2018-07-13 21:09 ` [PATCH/RFT 5/6] i2c: imx: " Wolfram Sang 2018-07-13 21:09 ` [PATCH/RFT 6/6] i2c: recovery: remove bogus check if SDA GPIO is set to output Wolfram Sang 2018-07-16 9:29 ` Ulrich Hecht
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180713210920.3648-5-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=kernel@pengutronix.de \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=nsekhar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.