All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
	"Masaharu Hayakawa" <masaharu.hayakawa.ry@renesas.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH v3 2/4] mmc: tmio: Fix SCC error detection
Date: Tue, 17 Jul 2018 16:52:14 +0200	[thread overview]
Message-ID: <20180717145216.16840-3-niklas.soderlund+renesas@ragnatech.se> (raw)
In-Reply-To: <20180717145216.16840-1-niklas.soderlund+renesas@ragnatech.se>

From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>

SDR104 and HS200 need to check for SCC error. If SCC error is detected,
retuning is necessary.

Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
[Niklas: update commit message]
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/host/tmio_mmc_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 72ac806e0c762d83..81883bc08524e441 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -920,8 +920,8 @@ static void tmio_mmc_finish_request(struct tmio_mmc_host *host)
 	if (mrq->cmd->error || (mrq->data && mrq->data->error))
 		tmio_mmc_abort_dma(host);
 
-	if (host->check_scc_error)
-		host->check_scc_error(host);
+	if (host->check_scc_error && host->check_scc_error(host))
+		mrq->cmd->error = -EILSEQ;
 
 	/* If SET_BLOCK_COUNT, continue with main command */
 	if (host->mrq && !mrq->cmd->error) {
-- 
2.18.0

  parent reply	other threads:[~2018-07-17 15:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 14:52 [PATCH v3 0/4] mmc: {tmio,renesas_sdhi}: fix tuning behavior Niklas Söderlund
2018-07-17 14:52 ` [PATCH v3 1/4] mmc: tmio: Fix tuning flow Niklas Söderlund
2018-07-18  8:48   ` Simon Horman
2018-07-24 10:42   ` Wolfram Sang
2018-07-24 10:58     ` Simon Horman
2018-07-24 11:19       ` Wolfram Sang
2018-07-17 14:52 ` Niklas Söderlund [this message]
2018-07-24 10:44   ` [PATCH v3 2/4] mmc: tmio: Fix SCC error detection Wolfram Sang
2018-07-24 11:03     ` Simon Horman
2018-07-24 11:17       ` Wolfram Sang
2018-07-24 12:17         ` Simon Horman
2018-07-17 14:52 ` [PATCH v3 3/4] mmc: renesas_sdhi: Fix sampling clock position selecting Niklas Söderlund
2018-07-18  8:52   ` Simon Horman
2018-07-24 11:26   ` Wolfram Sang
2018-07-24 12:19     ` Simon Horman
2018-07-24 14:57     ` Niklas Söderlund
2018-07-17 14:52 ` [PATCH v3 4/4] mmc: renesas_sdhi: skip SCC error check when retuning Niklas Söderlund
2018-07-18  8:54   ` Simon Horman
2018-07-18  9:46     ` Wolfram Sang
2018-07-18 12:23       ` Niklas Söderlund
2018-07-18 12:22     ` Niklas Söderlund
2018-07-19  7:40       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717145216.16840-3-niklas.soderlund+renesas@ragnatech.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=masaharu.hayakawa.ry@renesas.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.