All of lore.kernel.org
 help / color / mirror / Atom feed
From: dev-harsh1998 <harshitjain6751@gmail.com>
To: trivial@kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, Andi Shyti <andi@etezian.org>,
	Simon Budig <simon.budig@kernelconcepts.de>,
	Luca Ceresoli <luca@lucaceresoli.net>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] touchscreen: sun4i_ts: Use octal permissions
Date: Sun, 22 Jul 2018 00:39:50 +0530	[thread overview]
Message-ID: <20180721191029.25658-9-harshitjain6751@gmail.com> (raw)
In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com>

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL);

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL);

Signed-off-by: dev-harsh1998 <harshitjain6751@gmail.com>
---
 drivers/input/touchscreen/sun4i-ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c
index d2e14d9e5975..78960961a524 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -230,8 +230,8 @@ static ssize_t show_temp_label(struct device *dev,
 	return sprintf(buf, "SoC temperature\n");
 }
 
-static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL);
-static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL);
+static DEVICE_ATTR(temp1_input, 0444, show_temp, NULL);
+static DEVICE_ATTR(temp1_label, 0444, show_temp_label, NULL);
 
 static struct attribute *sun4i_ts_attrs[] = {
 	&dev_attr_temp1_input.attr,
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: harshitjain6751@gmail.com (dev-harsh1998)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] touchscreen: sun4i_ts: Use octal permissions
Date: Sun, 22 Jul 2018 00:39:50 +0530	[thread overview]
Message-ID: <20180721191029.25658-9-harshitjain6751@gmail.com> (raw)
In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com>

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL);

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL);

Signed-off-by: dev-harsh1998 <harshitjain6751@gmail.com>
---
 drivers/input/touchscreen/sun4i-ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c
index d2e14d9e5975..78960961a524 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -230,8 +230,8 @@ static ssize_t show_temp_label(struct device *dev,
 	return sprintf(buf, "SoC temperature\n");
 }
 
-static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL);
-static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL);
+static DEVICE_ATTR(temp1_input, 0444, show_temp, NULL);
+static DEVICE_ATTR(temp1_label, 0444, show_temp_label, NULL);
 
 static struct attribute *sun4i_ts_attrs[] = {
 	&dev_attr_temp1_input.attr,
-- 
2.17.1

  parent reply	other threads:[~2018-07-21 19:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 19:09 [PATCH 02/11] touchscreen: ad7877: Use octal permissions dev-harsh1998
2018-07-21 19:09 ` [PATCH 03/11] touchscreen: ad7846: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 04/11] touchscreen: amtel: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 05/11] touchscreen: elants: " dev-harsh1998
2018-07-22  9:39   ` Greg Kroah-Hartman
2018-07-21 19:09 ` [PATCH 06/11] touchscreen: ili210x: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 07/11] touchscreen: mc13783: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 08/11] touchscreen: melfas: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 09/11] touchscreen: raydium_ts: " dev-harsh1998
2018-07-21 19:09 ` dev-harsh1998 [this message]
2018-07-21 19:09   ` [PATCH 10/11] touchscreen: sun4i_ts: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 11/11] touchscreen: tsc200x: " dev-harsh1998
2018-07-23  5:08   ` Martin Kepplinger
2018-07-21 19:09 ` [PATCH 01/11] touchscreen: ft5x06: " dev-harsh1998
2018-07-22  8:29 ` [PATCH 02/11] touchscreen: ad7877: " Joe Perches
2018-07-23 13:19 dev-harsh1998
2018-07-23 13:19 ` [PATCH 10/11] touchscreen: sun4i_ts: " dev-harsh1998
2018-07-23 13:19   ` dev-harsh1998

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180721191029.25658-9-harshitjain6751@gmail.com \
    --to=harshitjain6751@gmail.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andi@etezian.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=maxime.ripard@bootlin.com \
    --cc=simon.budig@kernelconcepts.de \
    --cc=trivial@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.