From: "zhaowuyun@wingtech.com" <zhaowuyun@wingtech.com>
To: mgorman <mgorman@techsingularity.net>,
akpm <akpm@linux-foundation.org>, minchan <minchan@kernel.org>
Cc: vinmenon <vinmenon@codeaurora.org>, mhocko <mhocko@suse.com>,
hannes <hannes@cmpxchg.org>,
"hillf.zj" <hillf.zj@alibaba-inc.com>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] [PATCH] mm: disable preemption before swapcache_free
Date: Wed, 25 Jul 2018 14:37:58 +0800 [thread overview]
Message-ID: <2018072514375722198958@wingtech.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4426 bytes --]
From: zhaowuyun <zhaowuyun@wingtech.com>
issue is that there are two processes A and B, A is kworker/u16:8
normal priority, B is AudioTrack, RT priority, they are on the
same CPU 3.
The task A preempted by task B in the moment
after __delete_from_swap_cache(page) and before swapcache_free(swap).
The task B does __read_swap_cache_async in the do {} while loop, it
will never find the page from swapper_space because the page is removed
by the task A, and it will never sucessfully in swapcache_prepare because
the entry is EEXIST.
The task B then stuck in the loop infinitely because it is a RT task,
no one can preempt it.
so need to disable preemption until the swapcache_free executed.
TASK A:
=====================================================
Process: kworker/u16:8, cpu: 3 pid: 20289 start: 0xffffffc0385f8e00
=====================================================
Task name: kworker/u16:8 pid: 20289 cpu: 3 start: ffffffc0385f8e00
state: 0x0 exit_state: 0x0 stack base: 0xffffffc012ba0000 Prio: 120
Stack:
[<ffffff80bca861a4>] __switch_to+0x90
[<ffffff80bd83eddc>] __schedule+0x29c
[<ffffff80bd83f600>] preempt_schedule_common+0x24
[<ffffff80bd83f63c>] preempt_schedule.part.169+0x1c
[<ffffff80bd83f664>] preempt_schedule+0x20
[<ffffff80bd84396c>] _raw_spin_unlock_irqrestore+0x40
[<ffffff80bcbc4710>] __remove_mapping+0x174
[<ffffff80bcbc7698>] shrink_page_list+0x894
[<ffffff80bcbc7d7c>] reclaim_pages_from_list+0xc8
[<ffffff80bcc7b910>] reclaim_pte_range+0x158
[<ffffff80bcbf45d4>] walk_pgd_range+0xd4
[<ffffff80bcbf476c>] walk_page_range+0x74
[<ffffff80bcc7cd64>] reclaim_task_anon+0xdc
[<ffffff80bcc0a4c4>] swap_fn+0x1b8
[<ffffff80bcac2e88>] process_one_work+0x168
[<ffffff80bcac33a0>] worker_thread+0x224
[<ffffff80bcac9864>] kthread+0xe0
[<ffffff80bca836e0>] ret_from_fork+0x10
TASK B:
[535478.724249] CPU: 3 PID: 4645 Comm: AudioTrack Tainted: GF UD W O 4.9.82-perf+ #1
[535478.724385] Hardware name: Qualcomm Technologies, Inc. SDM450 PMI632 MTP S3 (DT)
[535478.724479] task: ffffffc026ce2a00 task.stack: ffffffc012e14000
[535478.724537] PC is at __read_swap_cache_async+0x154/0x25c
[535478.724630] LR is at __read_swap_cache_async+0x9c/0x25c
...
[535478.735546] [<ffffff80bcbf9970>] __read_swap_cache_async+0x154/0x25c
[535478.735599] [<ffffff80bcbf9a98>] read_swap_cache_async+0x20/0x54
[535478.735697] [<ffffff80bcbf9b24>] swapin_readahead+0x58/0x218
[535478.735797] [<ffffff80bcbe5240>] do_swap_page+0x3c4/0x4d0
[535478.735850] [<ffffff80bcbe6bf8>] handle_mm_fault+0x364/0xba4
[535478.735949] [<ffffff80bca9b5a8>] do_page_fault+0x2a0/0x38c
[535478.736003] [<ffffff80bca9b79c>] do_translation_fault+0x40/0x48
[535478.736100] [<ffffff80bca81340>] do_mem_abort+0x50/0xc8
Change-Id: I36d9df7ccff77c589b7157225410269c675a8504
Signed-off-by: zhaowuyun <zhaowuyun@wingtech.com>
---
mm/vmscan.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 2740973..acede002 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -674,6 +674,12 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
BUG_ON(!PageLocked(page));
BUG_ON(mapping != page_mapping(page));
+ /*
+ * preemption must be disabled to protect current task preempted before
+ * swapcache_free(swap) invoked by the task which do the
+ * __read_swap_cache_async job on the same page
+ */
+ preempt_disable();
spin_lock_irqsave(&mapping->tree_lock, flags);
/*
* The non racy check for a busy page.
@@ -714,6 +720,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
__delete_from_swap_cache(page);
spin_unlock_irqrestore(&mapping->tree_lock, flags);
swapcache_free(swap);
+ preempt_enable();
} else {
void (*freepage)(struct page *);
void *shadow = NULL;
@@ -740,6 +747,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
shadow = workingset_eviction(mapping, page);
__delete_from_page_cache(page, shadow);
spin_unlock_irqrestore(&mapping->tree_lock, flags);
+ preempt_enable();
if (freepage != NULL)
freepage(page);
@@ -749,6 +757,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
cannot_free:
spin_unlock_irqrestore(&mapping->tree_lock, flags);
+ preempt_enable();
return 0;
}
--
1.9.1
[-- Attachment #2: Type: text/html, Size: 6811 bytes --]
next reply other threads:[~2018-07-25 6:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 6:37 zhaowuyun [this message]
2018-07-25 6:40 ` [PATCH] [PATCH] mm: disable preemption before swapcache_free zhaowuyun
2018-07-25 7:40 ` Michal Hocko
2018-07-25 7:57 ` zhaowuyun
2018-07-25 8:21 ` Michal Hocko
2018-07-25 9:53 ` zhaowuyun
2018-07-25 10:34 ` Michal Hocko
2018-07-25 11:17 ` zhaowuyun
2018-07-25 10:32 ` Michal Hocko
2018-07-25 21:16 ` Andrew Morton
2018-07-26 2:21 ` zhaowuyun
2018-07-26 6:06 ` Michal Hocko
2018-07-26 7:03 ` zhaowuyun
2018-07-26 7:44 ` Michal Hocko
2018-07-26 22:11 ` Andrew Morton
2018-07-27 6:07 ` zhaowuyun
2018-08-04 23:07 ` Hugh Dickins
2018-08-07 2:15 ` zhaowuyun
2018-08-07 3:23 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2018072514375722198958@wingtech.com \
--to=zhaowuyun@wingtech.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.