From: Andrzej Hajda <a.hajda@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
dri-devel@lists.freedesktop.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 2/2] ARM: dts: exynos: arndale: fix HDMI-HPD line handling
Date: Thu, 26 Jul 2018 12:12:28 +0200 [thread overview]
Message-ID: <20180726101228.14956-2-a.hajda@samsung.com> (raw)
In-Reply-To: <20180726101228.14956-1-a.hajda@samsung.com>
HDMI-HPD was set active low, moreover by default pincontrol
chip sets pull-down on the pin. As a result HDMI driver
assumes TV is always connected regardless of actual state.
The patch fixes it.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 4 +++-
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 5 +++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 591023391f7d..26bae5157177 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -210,9 +210,11 @@
};
&hdmi {
+ pinctrl-names = "default";
+ pinctrl-0 = <&hdmi_hpd>;
status = "okay";
ddc = <&i2c_ddc>;
- hpd-gpios = <&gpx3 7 GPIO_ACTIVE_LOW>;
+ hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
vdd_osc-supply = <&ldo10_reg>;
vdd_pll-supply = <&ldo8_reg>;
vdd-supply = <&ldo8_reg>;
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index b25d520393b8..d31a68672bfa 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -599,6 +599,11 @@
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
};
+
+ hdmi_hpd: hdmi-hpd {
+ samsung,pins = "gpx3-7";
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+ };
};
&pinctrl_1 {
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-26 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180726101245eucas1p16d84c77490d9eb81300f38c2f3fb34a5@eucas1p1.samsung.com>
2018-07-26 10:12 ` [PATCH 1/2] ARM: dts: exynos: arndale: use i2c-gpio for HDMI-DDC Andrzej Hajda
[not found] ` <CGME20180726101248eucas1p14ede2f90176b93f0bfde1808b494abbd@eucas1p1.samsung.com>
2018-07-26 10:12 ` Andrzej Hajda [this message]
2018-07-26 10:44 ` [PATCH 2/2] ARM: dts: exynos: arndale: fix HDMI-HPD line handling Krzysztof Kozlowski
2018-07-26 11:50 ` Andrzej Hajda
2018-07-26 11:55 ` Krzysztof Kozlowski
2018-08-29 18:58 ` Krzysztof Kozlowski
2018-07-26 10:23 ` [PATCH 1/2] ARM: dts: exynos: arndale: use i2c-gpio for HDMI-DDC Krzysztof Kozlowski
2018-07-26 11:04 ` Andrzej Hajda
2018-07-26 11:51 ` Krzysztof Kozlowski
[not found] ` <CGME20180726132213eucas1p221b5ec5eb4a5e9c9d2ff1d76c7b26b2c@eucas1p2.samsung.com>
2018-07-26 13:22 ` [PATCH v2 " Andrzej Hajda
2018-07-26 13:47 ` Krzysztof Kozlowski
2018-08-29 18:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726101228.14956-2-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.