From: Ladislav Michl <ladis@linux-mips.org>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>, anish kumar <yesanishhere@gmail.com>
Subject: [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown
Date: Sat, 28 Jul 2018 17:42:26 +0200 [thread overview]
Message-ID: <20180728154226.GB9665@lenoch> (raw)
In-Reply-To: <20180728154134.GA9665@lenoch>
Move device enable to probe function to make line bypass
and mic sidetone work. Doing that from prepare callback
lets only DAC to produce output.
While here move suspend and resume functions to the more
common place.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
sound/soc/codecs/max9867.c | 62 +++++++++++++++-----------------------
sound/soc/codecs/max9867.h | 2 +-
2 files changed, 26 insertions(+), 38 deletions(-)
diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 4ea3287162ad..d7c96aa0d797 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -248,17 +248,6 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-static int max9867_prepare(struct snd_pcm_substream *substream,
- struct snd_soc_dai *dai)
-{
- struct snd_soc_component *component = dai->component;
- struct max9867_priv *max9867 = snd_soc_component_get_drvdata(component);
-
- regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
- MAX9867_SHTDOWN_MASK, MAX9867_SHTDOWN_MASK);
- return 0;
-}
-
static int max9867_mute(struct snd_soc_dai *dai, int mute)
{
struct snd_soc_component *component = dai->component;
@@ -361,7 +350,6 @@ static int max9867_dai_set_fmt(struct snd_soc_dai *codec_dai,
static const struct snd_soc_dai_ops max9867_dai_ops = {
.set_fmt = max9867_dai_set_fmt,
.set_sysclk = max9867_set_dai_sysclk,
- .prepare = max9867_prepare,
.digital_mute = max9867_mute,
.hw_params = max9867_dai_hw_params,
};
@@ -392,27 +380,6 @@ static struct snd_soc_dai_driver max9867_dai[] = {
}
};
-#ifdef CONFIG_PM_SLEEP
-static int max9867_suspend(struct device *dev)
-{
- struct max9867_priv *max9867 = dev_get_drvdata(dev);
-
- /* Drop down to power saving mode when system is suspended */
- regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
- MAX9867_SHTDOWN_MASK, ~MAX9867_SHTDOWN_MASK);
- return 0;
-}
-
-static int max9867_resume(struct device *dev)
-{
- struct max9867_priv *max9867 = dev_get_drvdata(dev);
-
- regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
- MAX9867_SHTDOWN_MASK, MAX9867_SHTDOWN_MASK);
- return 0;
-}
-#endif
-
static const struct snd_soc_component_driver max9867_component = {
.controls = max9867_snd_controls,
.num_controls = ARRAY_SIZE(max9867_snd_controls),
@@ -493,19 +460,40 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
ret = regmap_read(max9867->regmap,
MAX9867_REVISION, ®);
if (ret < 0) {
- dev_err(&i2c->dev, "Failed to read: %d\n", ret);
+ dev_err(&i2c->dev, "Failed to read revision: %d\n", ret);
return ret;
}
dev_info(&i2c->dev, "device revision: %x\n", reg);
- ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
- max9867_dai, ARRAY_SIZE(max9867_dai));
+ ret = regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
+ MAX9867_SHTDOWN, MAX9867_SHTDOWN);
if (ret < 0) {
- dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
+ dev_err(&i2c->dev, "Failed to enable: %d\n", ret);
return ret;
}
+ ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
+ max9867_dai, ARRAY_SIZE(max9867_dai));
+ if (ret < 0)
+ dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
return ret;
}
+static int __maybe_unused max9867_suspend(struct device *dev)
+{
+ struct max9867_priv *max9867 = dev_get_drvdata(dev);
+
+ /* Drop down to power saving mode when system is suspended */
+ return regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
+ MAX9867_SHTDOWN, 0);
+}
+
+static int __maybe_unused max9867_resume(struct device *dev)
+{
+ struct max9867_priv *max9867 = dev_get_drvdata(dev);
+
+ return regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
+ MAX9867_SHTDOWN, MAX9867_SHTDOWN);
+}
+
static const struct i2c_device_id max9867_i2c_id[] = {
{ "max9867", 0 },
{ }
diff --git a/sound/soc/codecs/max9867.h b/sound/soc/codecs/max9867.h
index 55cd9976ff47..d9170850c96e 100644
--- a/sound/soc/codecs/max9867.h
+++ b/sound/soc/codecs/max9867.h
@@ -67,7 +67,7 @@
#define MAX9867_MICCONFIG 0x15
#define MAX9867_MODECONFIG 0x16
#define MAX9867_PWRMAN 0x17
-#define MAX9867_SHTDOWN_MASK (1<<7)
+#define MAX9867_SHTDOWN 0x80
#define MAX9867_REVISION 0xff
#define MAX9867_CACHEREGNUM 10
--
2.18.0
next prev parent reply other threads:[~2018-07-28 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 15:41 [PATCH v0 0/3] ASoC: max9867: driver update Ladislav Michl
2018-07-28 15:42 ` Ladislav Michl [this message]
2018-07-30 9:23 ` [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown Mark Brown
2018-07-28 15:43 ` [PATCH v0 2/3] ASoC: max9867: Calculate LRCLK divider Ladislav Michl
2018-07-28 15:44 ` [PATCH v0 3/3] ASoC: max9867: Fix volume controls Ladislav Michl
2018-07-30 10:11 ` Mark Brown
2018-07-30 10:45 ` Ladislav Michl
2018-07-30 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728154226.GB9665@lenoch \
--to=ladis@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.