All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, yangx.jy@cn.fujitsu.com
Subject: [PATCH v2 1/2] xfs/288: use -d option of xfs_db write command for v5 XFS
Date: Tue, 31 Jul 2018 13:41:18 +0800	[thread overview]
Message-ID: <20180731054119.13539-1-zlang@redhat.com> (raw)

The commit b3cf8b72334fd35ef961869506e5a72ab398bc82 update xfs/288
to support v5 filesystem testing. That commit thought xfs_db write
command can work well with -d option on V5 XFS. But the truth is
the case doesn't use that option.

So turn to use _scratch_xfs_set_metadata_field, it will help to use
proper options for xfs_db write command.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

This patch has been reviewed by Darrick J. Wong:
https://marc.info/?l=linux-xfs&m=153287978423915&w=2

I sent this patch again only because it's related with next [2/2] patch.

Thanks,
Zorro

 tests/xfs/288 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/xfs/288 b/tests/xfs/288
index bccdb6fc..f4165b6c 100755
--- a/tests/xfs/288
+++ b/tests/xfs/288
@@ -56,9 +56,8 @@ $SETFATTR_PROG -n "user.testattr${seq}" \
 
 _scratch_unmount
 # manually corrupt the XFS, by set the header count of attr to 0
-_scratch_xfs_db -x -c "inode $inum" \
-		   -c "ablock 0" \
-		   -c "write hdr.count 0" >> $seqres.full
+_scratch_xfs_set_metadata_field "hdr.count" "0" \
+				"inode $inum" "ablock 0" >> $seqres.full
 
 # make sure xfs_repair can find above corruption. If it can't, that
 # means we need to fix this bug on current xfs_repair
-- 
2.14.4


             reply	other threads:[~2018-07-31  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  5:41 Zorro Lang [this message]
2018-07-31  5:41 ` [PATCH v2 2/2] xfs/288: _notrun if xfs_db can't write values into dir or attr Zorro Lang
2018-08-02  0:46   ` Darrick J. Wong
2018-08-02  1:49     ` Zorro Lang
2018-08-02  5:14       ` Darrick J. Wong
2018-08-02  7:10         ` Zorro Lang
2018-08-06  0:32   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731054119.13539-1-zlang@redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.