All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH 7/7] btrfs: Remove redundant btrfs_release_path from btrfs_unlink_subvol
Date: Wed, 1 Aug 2018 11:32:31 +0800	[thread overview]
Message-ID: <20180801033231.23166-8-lufq.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20180801033231.23166-1-lufq.fnst@cn.fujitsu.com>

Although it is safe to call this on paths that no locks or extent buffers
held, removing the redundant btrfs_release_path is reasonable.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
 fs/btrfs/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index b8c131b82978..7e56a203c109 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4137,7 +4137,6 @@ static int btrfs_unlink_subvol(struct btrfs_trans_handle *trans,
 
 		leaf = path->nodes[0];
 		btrfs_item_key_to_cpu(leaf, &key, path->slots[0]);
-		btrfs_release_path(path);
 		index = key.offset;
 	}
 	btrfs_release_path(path);
-- 
2.18.0




  parent reply	other threads:[~2018-08-01  5:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  3:32 [PATCH 0/7] Some unused parameter cleanup Lu Fengqi
2018-08-01  3:32 ` [PATCH 1/7] btrfs: Remove fs_info from btrfs_insert_delayed_dir_index Lu Fengqi
2018-08-01  3:32 ` [PATCH 2/7] btrfs: Remove fs_info from btrfs_delete_delayed_dir_index Lu Fengqi
2018-08-01  3:32 ` [PATCH 3/7] btrfs: Remove fs_info from btrfs_del_root Lu Fengqi
2018-08-01  3:32 ` [PATCH 4/7] btrfs: Remove fs_info from btrfs_del_root_ref Lu Fengqi
2018-08-01  3:32 ` [PATCH 5/7] btrfs: Remove fs_info from btrfs_add_root_ref Lu Fengqi
2018-08-01  3:32 ` [PATCH 6/7] btrfs: Remove root parameter from btrfs_unlink_subvol Lu Fengqi
2018-08-01  3:32 ` Lu Fengqi [this message]
2018-08-01 12:53 ` [PATCH 0/7] Some unused parameter cleanup David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801033231.23166-8-lufq.fnst@cn.fujitsu.com \
    --to=lufq.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.